Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: inline volume support #905

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: inline volume support #905

merged 2 commits into from
Jan 17, 2025
+599 −8

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: inline volume support

Which issue(s) this PR fixes:

Fixes #783

Requirements:

Special notes for your reviewer:

Release note:

feat: inline volume support

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Jan 12, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 12, 2025
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 12, 2025
@coveralls
Copy link

coveralls commented Jan 12, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12830218881

Details

  • 78 of 112 (69.64%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.9%) to 78.455%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/nodeserver.go 34 38 89.47%
pkg/smb/smb.go 34 64 53.13%
Totals Coverage Status
Change from base Build 12729821630: -0.9%
Covered Lines: 1107
Relevant Lines: 1411
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

2 similar comments
@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-smb-e2e-windows-2019-hostprocess
/test pull-csi-driver-smb-e2e-windows-2022-hostprocess

@andyzhangx
Copy link
Member Author

/retest

2 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

3 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
feat: add feature flag for inline volume support
9df3b58 
test: add ut

fix

fix

fix

fix

fix
@andyzhangx andyzhangx merged commit 613018d into kubernetes-csi:master Jan 17, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
3 participants
@andyzhangx @k8s-ci-robot @coveralls