Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use new restricted liveness probe endpoint #766

Merged
merged 2 commits into from
Apr 2, 2024
Merged

feat: use new restricted liveness probe endpoint #766

merged 2 commits into from
Apr 2, 2024

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: use new restricted liveness probe endpoint

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: use new restricted liveness probe endpoint

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 1, 2024
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2024
@coveralls
Copy link

coveralls commented Apr 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8503537377

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.293%
Totals Coverage Status
Change from base Build 8476907307: 0.0%
Covered Lines: 942
Relevant Lines: 1188
💛 - Coveralls

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 1, 2024
@andyzhangx andyzhangx merged commit d7d14f1 into kubernetes-csi:master Apr 2, 2024
20 of 21 checks passed
@sushain97
Copy link

Just an FYI that upgrading my chart to v1.14.0 to include this change resulted in it the deployment crashlooping due to a failing healthcheck. I've downgraded to v1.13.0 and things are healthy again.

@andyzhangx
Copy link
Member Author

Just an FYI that upgrading my chart to v1.14.0 to include this change resulted in it the deployment crashlooping due to a failing healthcheck. I've downgraded to v1.13.0 and things are healthy again.

@sushain97 is it failing on linux node or windows node?

@sushain97
Copy link

sushain97 commented Apr 10, 2024 •
edited
Loading 

kube:~# uname -a
Linux kube.local.skc.name 6.1.84-0-lts #1-Alpine SMP PREEMPT_DYNAMIC Thu, 04 Apr 2024 09:15:32 +0000 x86_64 Linux

@andyzhangx
Copy link
Member Author

@sushain97 which pod is crashing? controller pod or daemonset pod?

andyzhangx
andyzhangx commented Apr 10, 2024
View reviewed changes
charts/v1.14.0/csi-driver-smb/templates/csi-smb-controller.yaml
path: /healthz
port: healthz
port: {{ .Values.node.livenessProbe.healthPort }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sushain97 I found the bug!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stupid copy & paste bug

@andyzhangx
Copy link
Member Author

@sushain97 which pod is crashing? controller pod or daemonset pod?

@sushain97 would be fixed by #769

@sushain97
Copy link

sushain97 commented Apr 10, 2024 •
edited
Loading

@sushain97 which pod is crashing? controller pod or daemonset pod?

@sushain97 would be fixed by #769

Thanks! :)

FWIW, I'm a little confused by the versioning here. I assumed that v1.14.0 wouldn't change after Jan 16 (https://github.com/kubernetes-csi/csi-driver-smb/releases/tag/v1.14.0) but it appears that it's being changed even in #769? I would have expected a v1.14.1.

@andyzhangx
Copy link
Member Author

@sushain97 v1.14.0 image won't change, but I changed the helm chart config a little to not expose one port on the node

@andyzhangx
Copy link
Member Author

@sushain97 PR merged, could you run helm repo update and then install v1.14.0 chart again, thanks.

@sushain97
Copy link

Looks like it works now! Thanks for the speedy fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andyzhangx @k8s-ci-robot @coveralls @sushain97