Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix TestNodeStageVolume on Windows #115

Merged
merged 1 commit into from
Sep 10, 2020
Merged

test: Fix TestNodeStageVolume on Windows #115

merged 1 commit into from
Sep 10, 2020

Conversation

mayankshah1607
Copy link
Contributor

@mayankshah1607 mayankshah1607 commented Sep 10, 2020 •
edited
Loading

Signed-off-by: Mayank Shah [email protected]

What type of PR is this?

What this PR does / why we need it:
Fix TestNodeStageVolume on Windows

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @mayankshah1607. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2020
@mayankshah1607
Copy link
Contributor Author

mayankshah1607 commented Sep 10, 2020 •
edited
Loading

@andyzhangx I have tried to take a different approach for making the tests compatible across Windows as well as Linux. I have introduced a TestError struct, that holds errors for Windows and Linux, and assert on them accordingly by checking the OS.
If this approach is fine, I shall make changes to the remaining tests as well

@coveralls
Copy link

coveralls commented Sep 10, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 247995257

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.819%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/smb/nodeserver.go 0 1 0.0%
Totals Coverage Status
Change from base Build 247616749: 0.0%
Covered Lines: 620
Relevant Lines: 706
💛 - Coveralls

@mayankshah1607 mayankshah1607 force-pushed the mayank/windows-test branch 2 times, most recently from 57f41c6 to fe2787f Compare September 10, 2020 11:57
mayankshah1607
mayankshah1607 commented Sep 10, 2020
View reviewed changes
pkg/smb/fake_mounter_test.go
Comment on lines +28 to +29
targetTest := "./target_test"
sourceTest := "./source_test"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whenever these tests are refactored, we'll similarly change the hard coded paths to testutil.GetWorkDirPath

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anything you want to do in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I think we can merge this one. I will open a follow up PR for refactoring remaining tests on this repo, as well as on the azurefile and azure disk repos

@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 10, 2020
andyzhangx
andyzhangx approved these changes Sep 10, 2020
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit 74c82c2 into kubernetes-csi:master Sep 10, 2020
@mayankshah1607 mayankshah1607 mentioned this pull request Oct 27, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mayankshah1607 @k8s-ci-robot @coveralls @andyzhangx