Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use golangci-lint-action #118

Closed
andyzhangx opened this issue Sep 23, 2020 · 4 comments · Fixed by #119
Closed

use golangci-lint-action #118

andyzhangx opened this issue Sep 23, 2020 · 4 comments · Fixed by #119
Assignees
@mayankshah1607
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@andyzhangx
Copy link
Member

andyzhangx commented Sep 23, 2020 •
edited
Loading

Is your feature request related to a problem?/Why is this needed

Describe the solution you'd like in detail

https://github.com/golangci/golangci-lint-action
should set up golangci-lint-action first and then if it's stable enough, retire original hack/verify-golint.sh

cc @mayankshah1607

Describe alternatives you've considered

Additional context
@andyzhangx andyzhangx added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 23, 2020
@boddumanohar
Copy link
Contributor

I would like to take this task up.

@boddumanohar
Copy link
Contributor

I am sorry, Mayank has been 'cced. I didn't see that.

@mayankshah1607 mayankshah1607 mentioned this issue Sep 23, 2020
Merged
4 tasks
@mayankshah1607
Copy link
Contributor

/assign

@mayankshah1607
Copy link
Contributor

mayankshah1607 commented Sep 23, 2020 •
edited
Loading

I am sorry, Mayank has been 'cced. I didn't see that.

No problem, @boddumanohar ! :)

andyzhangx pushed a commit to andyzhangx/csi-driver-smb that referenced this issue May 1, 2022
@k8s-ci-robot
Merge pull request kubernetes-csi#118 from pohly/cloud-build-timeout
3b6d17b 
cloud build: double the timeout, now 1 hour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mayankshah1607 mayankshah1607

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Use golangci-lint-action for running linters mayankshah1607/csi-driver-smb
3 participants
@andyzhangx @boddumanohar @mayankshah1607