Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make CSI driver work on 1.22 #233

Merged
merged 1 commit into from
Oct 9, 2021
Merged

fix: make CSI driver work on 1.22 #233

merged 1 commit into from
Oct 9, 2021

Conversation

andyzhangx
Copy link
Member

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: make CSI driver work on 1.22

Which issue(s) this PR fixes:

Fixes #232

Special notes for your reviewer:

install.go:178: [debug] Original chart version: ""
install.go:199: [debug] CHART PATH: /home/irispulse/helms/csi-driver-nfs
Error: INSTALLATION FAILED: unable to build kubernetes objects from release manifest: unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1beta1"
helm.go:88: [debug] unable to recognize "": no matches for kind "CSIDriver" in version "storage.k8s.io/v1beta1"

Does this PR introduce a user-facing change?:

fix: make CSI driver work on 1.22

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from pohly October 9, 2021 02:34
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2021
@andyzhangx
Copy link
Member Author

cc @malikumaliku

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1322557575

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 78.698%
Totals Coverage Status
Change from base Build 1264775369: 0.0%
Covered Lines: 532
Relevant Lines: 676
💛 - Coveralls

@andyzhangx
Copy link
Member Author

/test pull-csi-driver-nfs-external-e2e

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx andyzhangx merged commit 8ad6bea into kubernetes-csi:master Oct 9, 2021
andyzhangx added a commit to andyzhangx/csi-driver-nfs that referenced this pull request Aug 14, 2023
@andyzhangx
Squashed 'release-tools/' changes from 670bb0e..de2fba8
ec446a6 
de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1
cee895e remove windows 20H2 build since it's EOL long time ago

git-subtree-dir: release-tools
git-subtree-split: de2fba8
TerryHowe pushed a commit to TerryHowe/csi-driver-nfs that referenced this pull request Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1
de2fba8 
remove windows 20H2 build since it's EOL long time ago
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j-griffith j-griffith Awaiting requested review from j-griffith

@pohly pohly Awaiting requested review from pohly

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

helm charts not working in k8s 1.22
3 participants
@andyzhangx @k8s-ci-robot @coveralls