CI: enable golint #109
Merged
CI: enable golint #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
k8s-ci-robot
added
the
size/S
mayankshah1607
force-pushed
the
mayank/lint
branch
7 times, most recently
from
e0a77f4 to
210fbe4
Compare
k8s-ci-robot
added
size/M
Signed-off-by: Mayank Shah <[email protected]>
mayankshah1607
force-pushed
the
mayank/lint
branch
from
210fbe4 to
2738092
Compare
msau42
pushed a commit
to msau42/csi-driver-nfs
that referenced
this pull request
Dec 1, 2020
prow.sh: only run alpha tests for latest Kubernetes release
msau42
pushed a commit
to msau42/csi-driver-nfs
that referenced
this pull request
Dec 1, 2020
4aff857 Merge pull request kubernetes-csi#109 from pohly/alpha-test-defaults 0427289 Merge pull request kubernetes-csi#110 from pohly/kind-0.9-bazel-build-workaround 9a370ab prow.sh: work around "kind build node-image" failure 522361e prow.sh: only run alpha tests for latest Kubernetes release 22c0395 Merge pull request kubernetes-csi#108 from bnrjee/master b5b447b Add go ldflags using LDFLAGS at the time of compilation 16f4afb Merge pull request kubernetes-csi#107 from pohly/kind-update 7bcee13 prow.sh: update to kind 0.9, support Kubernetes 1.19 df518fb prow.sh: usage of Bazel optional c3afd42 Merge pull request kubernetes-csi#104 from xing-yang/snapshot dde93b2 Update to snapshot-controller v3.0.0 git-subtree-dir: release-tools git-subtree-split: 4aff857
andyzhangx
approved these changes
Dec 2, 2020
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, mayankshah1607 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
maybe you could help? @dr0pdb thanks. |
|
@andyzhangx SMB driver already has this check running - https://github.com/kubernetes-csi/csi-driver-smb/blob/master/.github/workflows/static.yaml |
not needed any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mayank Shah [email protected]
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #90
Special notes for your reviewer:
Does this PR introduce a user-facing change?: