-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update plugin version in the readme #81
Conversation
/assign @andyzhangx |
``` | ||
$ csc identity plugin-info --endpoint tcp://127.0.0.1:10000 | ||
"ISCSI" "0.1.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first alpha version should be 0.1.0
and then 1.0.0
should be GA version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyzhangx the driver version in the code is 1.0.0
, https://github.com/kubernetes-csi/csi-driver-iscsi/blob/master/pkg/iscsi/driver.go#L44 , so this correction. Considering the plan is to release I think we have to confirm the release state and then correct accordingly. Looks like its good to release alpha
first . If we are in agreement, I will change the driver version in the code then? wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's use 0.1.0
for alpha first, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyzhangx done. ptal . thanks
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
Signed-off-by: Humble Chirammal <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andyzhangx, humblec The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit update the readme with the driver version available
in the deploy directory along with some other markdown corrections
in the same file.
Signed-off-by: Humble Chirammal [email protected]
-->