Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update build actions to latest releases #141

Closed
wants to merge 2 commits into from

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Aug 24, 2022

Signed-off-by: Humble Chirammal [email protected]

/kind cleanup

Depends# #142

none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Aug 24, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 24, 2022
In absence of this, the linter fails with below:
```
Error: ./pkg/iscsi/iscsi_util.go:72: ro ==> to, row, rob, rod, roe, rot
```

where `ro` is a valid mode of operation

Signed-off-by: Humble Chirammal <[email protected]>
@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 24, 2022
humblec added a commit to humblec/csi-lib-iscsi that referenced this pull request Sep 1, 2022
This formatting issue has been reported under csi-driver-iscsi repo
and blocking the PR merge.

kubernetes-csi/csi-driver-iscsi#141

Signed-off-by: Humble Chirammal <[email protected]>
@humblec humblec closed this Sep 3, 2022
TerryHowe pushed a commit to TerryHowe/csi-driver-iscsi that referenced this pull request Oct 17, 2024
go-get-kubernetes.sh: make replace statement pruning optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants