Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to put targetd parameters in StorageClass like in old targed iscsi-provisioner #234

Closed
lukasg-d opened this issue Dec 4, 2023 · 7 comments
Closed

Ability to put targetd parameters in StorageClass like in old targed iscsi-provisioner #234

lukasg-d opened this issue Dec 4, 2023 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@lukasg-d
Copy link

lukasg-d commented Dec 4, 2023

Is your feature request related to a problem?/Why is this needed

At this moment, according to examples, targetd parameters can be only placed in PV, to reduce burden we'd like to have it in one place

Describe the solution you'd like in detail

Ability to have iscsi connection details in one place, ie. StorageClass in similar way like old targetd iscsi-provisioner had:

parameters:
  chapAuthDiscovery: 'false'
  chapAuthSession: 'false'
  fsType: ext4
  initiators: >-
    iqn.x.y.z:node1,iqn.x.y.z:node2,iqn.x.y.z:node3,iqn.x.y.z:node4
  iqn: iqn.x.y.z:targetd
  targetPortal: 192.x.y.z:3260
  volumeGroup: lvm-iscsi

Describe alternatives you've considered

Old targetd iscsi-provisioner

Additional context
@lukasg-d lukasg-d changed the title Ability to put targed parameters in StorageClass like in old targed iscsi-provisioner Ability to put targetd parameters in StorageClass like in old targed iscsi-provisioner Dec 4, 2023
andyzhangx added a commit to andyzhangx/csi-driver-iscsi that referenced this issue Dec 16, 2023
@andyzhangx
Squashed 'release-tools/' changes from 670bb0e..b54c1ba
159c9a0 
b54c1ba Merge pull request kubernetes-csi#246 from xing-yang/go_1.21
5436c81 Change go version to 1.21.5
267b40e Merge pull request kubernetes-csi#244 from carlory/sig-storage
b42e5a2 nominate self (carlory) as kubernetes-csi reviewer
a17f536 Merge pull request kubernetes-csi#210 from sunnylovestiramisu/sidecar
011033d Use set -x instead of die
5deaf66 Add wrapper script for sidecar release
f8c8cc4 Merge pull request kubernetes-csi#237 from msau42/prow
b36b5bf Merge pull request kubernetes-csi#240 from dannawang0221/upgrade-go-version
adfddcc Merge pull request kubernetes-csi#243 from pohly/git-subtree-pull-fix
c465088 pull-test.sh: avoid "git subtree pull" error
7b175a1 Update csi-test version to v5.2.0
987c90c Update go version to 1.21 to match k/k
2c625d4 Add script to generate patch release notes
f9d5b9c Merge pull request kubernetes-csi#236 from mowangdk/feature/bump_csi-driver-host-path_version
b01fd53 Bump csi-driver-host-path version up to v1.12.0
984feec Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools
1f7e605 fixed broken links of testgrid dashboard
de2fba8 Merge pull request kubernetes-csi#233 from andyzhangx/andyzhangx-patch-1
cee895e remove windows 20H2 build since it's EOL long time ago

git-subtree-dir: release-tools
git-subtree-split: b54c1ba
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 2, 2024
@jmrr
Copy link

jmrr commented Apr 18, 2024

Hi @lukasg-d, did you manage to get a storage class working similar to the one with the iscsi-provisioner? It's unclear whether the provisioner of this csi driver would accept the right storage class parameters.

@lukasg-d
Copy link
Author

Hi, at the time of writing previous comment I couldn't make it working, so I assume that csi driver is not accepting right storage class parameters.

@andyzhangx
Copy link
Member

that's because this driver does not implement CreateVolume api, storage class won't work:

csi-driver-iscsi/pkg/iscsi/controllerserver.go

Line 32 in 554efb1

return nil, status.Error(codes.Unimplemented, "")

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale May 18, 2024
TerryHowe pushed a commit to TerryHowe/csi-driver-iscsi that referenced this issue Oct 17, 2024
@k8s-ci-robot
Merge pull request kubernetes-csi#234 from siddhikhapare/csi-tools
984feec 
fixed broken links of testgrid dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@andyzhangx @jmrr @k8s-ci-robot @k8s-triage-robot @lukasg-d