Skip to content

Commit

Permalink
Merge pull request #305 from TerryHowe/update-golang-lint
Browse files Browse the repository at this point in the history
chore: update golang lint workflow
  • Loading branch information
k8s-ci-robot authored Oct 19, 2024
2 parents bccce0d + 3dfd0cb commit 0bf7bcc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ jobs:
- name: Set up Go 1.x
uses: actions/setup-go@v5
with:
go-version: ^1.19
go-version: ^1.22
- uses: actions/checkout@master
- name: Run linter
uses: golangci/golangci-lint-action@v6
with:
version: v1.54
args: -E=gofmt,unused,ineffassign,misspell,exportloopref,asciicheck,bodyclose,dogsled,durationcheck,errname,forbidigo -D=staticcheck --timeout=30m0s
version: v1.61
args: -E=gofmt,unused,ineffassign,misspell,copyloopvar,asciicheck,bodyclose,dogsled,durationcheck,errname,forbidigo -D=staticcheck --timeout=30m0s
2 changes: 1 addition & 1 deletion pkg/iscsilib/iscsi.go
Original file line number Diff line number Diff line change
Expand Up @@ -517,7 +517,7 @@ func GetISCSIDevices(devicePaths []string, strict bool) (devices []Device, err e
func lsblk(devicePaths []string, strict bool) (deviceInfo, error) {
flags := []string{"-rn", "-o", "NAME,KNAME,PKNAME,HCTL,TYPE,TRAN,SIZE"}
command := execCommand("lsblk", append(flags, devicePaths...)...)
klog.V(2).Infof(command.String())
klog.V(2).Info(command.String())
out, err := command.Output()
if err != nil {
if ee, ok := err.(*exec.ExitError); ok {
Expand Down

0 comments on commit 0bf7bcc

Please sign in to comment.