-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce SINGLE_NODE_SINGLE_WRITER access mode in NodePublishVolume #381
Enforce SINGLE_NODE_SINGLE_WRITER access mode in NodePublishVolume #381
Conversation
Using shared mounter across NodePublishVolume method.
165162b
to
802b188
Compare
Return FAILED_PRECONDITION if a volume in NodePublish uses the SINGLE_NODE_SINGLE_WRITER access mode and is already mounted elsewhere on the node. See the second table in this section for more details: https://github.com/container-storage-interface/spec/blob/v1.7.0/spec.md#nodepublishvolume
802b188
to
bad0711
Compare
/retest Failed due to:
|
Bumping this, is there any other feedback I can address? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrishenzie, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Np, thx for the review! |
This version enforces the new SINGLE_NODE_SINGLE_WRITER CSI access mode in NodePublishVolume. See for more details: kubernetes-csi/csi-driver-host-path#381
What type of PR is this?
/kind feature
What this PR does / why we need it:
This is a first draft of adding support for
SINGLE_NODE_SINGLE_WRITER
access mode enforcement in the hostpath driver.See the second table in this section for more details:
https://github.com/container-storage-interface/spec/blob/v1.7.0/spec.md#nodepublishvolume
NOTE: This is hacky. Any suggestions for improvement are much appreciated.
Which issue(s) this PR fixes:
Fixes #380
Does this PR introduce a user-facing change?:
Testing:
This was tested using the k8s
e2e.test
binary to install the (custom) hostpath driver and run pods on the same host./sig storage
/cc @msau42
/cc @jsafrane