-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from k8s.gcr.io to registry.k8s.io #357
Conversation
Hi @yselkowitz. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @dims |
@yselkowitz: GitHub didn't allow me to request PR reviews from the following users: dims. Note that only kubernetes-csi members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes includes results of the following command: test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.8.0 This also includes backports from the following post-release commits: kubernetes-csi/csi-driver-host-path#355 kubernetes-csi/csi-driver-host-path#357 Also includes a manual update of the busybox image to match the tag used elsewhere in kubernetes e2e.
/ok-to-test |
@dims: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @jsafrane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pohly, yselkowitz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d4682ce
to
bfdb3e0
Compare
/ok-to-test |
@yselkowitz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
/lgtm |
Changes includes results of the following command: test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.8.0 This also includes backports from the following post-release commits: kubernetes-csi/csi-driver-host-path#355 kubernetes-csi/csi-driver-host-path#357 Also includes a manual update of the busybox image to match the tag used elsewhere in kubernetes e2e.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This updates the image registry in accordance with:
https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)
kubernetes/enhancements#3079
kubernetes/kubernetes#109938
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: