CSI ephemeral inline volume testing + fix #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note
k8s-ci-robot
added
size/XS
pohly
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
At least one line volume must be defined, otherwise the tests get skipped.
With storage capacity simulation enabled, trying to create ephemeral volumes with the default maximum volume size may have failed: Warning FailedMount 6s (x5 over 14s) kubelet MountVolume.SetUp failed for volume "ephemeral-volume" : rpc error: code = ResourceExhausted desc = not enough capacity: have 100Gi, need 1Ti Using a smaller size is better because then more than one volume can be created per host. Even better would be to also add a parameter for it, but that can be added later.
pohly
force-pushed
the
csi-ephemeral-volume-fix
branch
from
a85f6a2 to
93d4ef8
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @xing-yang For approval. |
xing-yang
reviewed
Mar 25, 2021
| @@ -64,7 +64,9 @@ func (hp *hostPath) NodePublishVolume(ctx context.Context, req *csi.NodePublishV | |||
| volID := req.GetVolumeId() | |||
| volName := fmt.Sprintf("ephemeral-%s", volID) | |||
| kind := req.GetVolumeContext()[storageKind] | |||
| vol, err := hp.createVolume(req.GetVolumeId(), volName, maxStorageCapacity, mountAccess, ephemeralVolume, kind) | |||
| // Configurable size would be nice. For now we use a small, fixed volume size of 100Mi. | |||
There was a problem hiding this comment.
Any specific reason why 100Mi is the chosen size?
There was a problem hiding this comment.
It's small enough that with the default fake capacity limits a large number of inline volumes can be created. But other than that, no.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
humblec
added a commit
to humblec/csi-driver-host-path
that referenced
this pull request
May 24, 2024
4967685 Merge pull request kubernetes-csi#254 from bells17/add-github-actions d9bd160 Update skip list in codespell GitHub Action adb3af9 Merge pull request kubernetes-csi#252 from bells17/update-go-version f5aebfc Add GitHub Actions workflows b82ee38 Merge pull request kubernetes-csi#253 from bells17/fix-typo c317456 Fix typo 0a78505 Bump to Go 1.22.3 edd89ad Merge pull request kubernetes-csi#251 from jsafrane/add-logcheck 043fd09 Add test-logcheck target d7535ae Merge pull request kubernetes-csi#250 from jsafrane/go-1.22 b52e7ad Update go to 1.22.2 14fdb6f Merge pull request kubernetes-csi#247 from msau42/prow 9b4352e Update release playbook c7bb972 Fix release notes script to use fixed tags 463a0e9 Add script to update specific go modules git-subtree-dir: release-tools git-subtree-split: 4967685
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this pull request
Oct 17, 2024
Add GitHub Actions workflows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
At least one line volume must be defined, otherwise the tests
get skipped. This wasn't the case earlier, which is why support for CSI ephemeral inline volumes broke in release v1.6.0 when changing the size check.
Does this PR introduce a user-facing change?: