Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidecars and driver to latest versions #169

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

msau42
Copy link
Collaborator

@msau42 msau42 commented Apr 10, 2020

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Updates the sidecars and driver to the latest versions.

Removes deploy-hostpath.sh as it is a duplicate of deploy.sh

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add 1.18 deployment specs and update sidecar and driver versions.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 10, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2020
@msau42
Copy link
Collaborator Author

msau42 commented Apr 10, 2020

/hold
for testing against 1.18

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 10, 2020
@msau42
Copy link
Collaborator Author

msau42 commented Apr 10, 2020

Putting override here for reference:

CSI_PROW_KUBERNETES_VERSION="1.18.0"
CSI_PROW_KUBERNETES_DEPLOYMENT="1.18"

@msau42
Copy link
Collaborator Author

msau42 commented Apr 10, 2020

/assign @xing-yang @jsafrane
I will be adding 1.18 jobs after this merges

@msau42
Copy link
Collaborator Author

msau42 commented Apr 11, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2020
@@ -0,0 +1,2 @@
The deployment for Kubernetes 1.18 uses VolumeSnapshot Beta CRDs and thus is imcompatible
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/imcompatible/incompatible

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@xing-yang
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 539736a into kubernetes-csi:master Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants