Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Python3.4 #807

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Drop Python3.4 #807

merged 1 commit into from
Jul 9, 2019

Conversation

oz123
Copy link
Contributor

@oz123 oz123 commented Apr 5, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 5, 2019
micw523
micw523 reviewed Apr 5, 2019
View reviewed changes
Copy link
Contributor

@micw523 micw523 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also drop python 3.4 from .travis.yml.
@roycaihw, do we want to drop Python 3.4 from PyPI as well?

@oz123
Drop Python3.4
e8fd4b9 
 Python3.4 become EOL on 2019.03.18.

 https://www.python.org/dev/peps/pep-0429/
@micw523
Copy link
Contributor

micw523 commented Apr 5, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 4, 2019
@micw523
Copy link
Contributor

micw523 commented Jul 8, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2019
@micw523
Copy link
Contributor

micw523 commented Jul 8, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 8, 2019
@roycaihw
Copy link
Member

roycaihw commented Jul 9, 2019

/lgtm
/approve

ref kubernetes-client/python-base#127

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oz123, roycaihw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@k8s-ci-robot k8s-ci-robot merged commit da8c843 into kubernetes-client:master Jul 9, 2019
@oz123 oz123 mentioned this pull request Jul 25, 2019
Merged
@scottilee scottilee mentioned this pull request Jul 26, 2019
Closed
@oz123 oz123 mentioned this pull request Aug 14, 2019
Closed
6 tasks
@roycaihw roycaihw mentioned this pull request Feb 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micw523 micw523 micw523 left review comments

@lavalamp lavalamp Awaiting requested review from lavalamp

@roycaihw roycaihw Awaiting requested review from roycaihw

Assignees

@roycaihw roycaihw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oz123 @micw523 @fejta-bot @roycaihw @k8s-ci-robot