Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use load_incluster_config in jupyther notebook examples #242

Closed
wants to merge 1 commit into from
Closed

Use load_incluster_config in jupyther notebook examples #242

wants to merge 1 commit into from

Conversation

pokoli
Copy link

@pokoli pokoli commented Jun 5, 2017

Closes #219

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 5, 2017
@mbohlool mbohlool requested a review from djkonro June 5, 2017 15:58
@sebgoa
Copy link
Contributor

sebgoa commented Jun 7, 2017

I'd rather merge #239 and close this one. #239 address is a complete notebook.

We need to revisit all notebooks with a try/except maybe to load in both cases.

@mbohlool mbohlool closed this Jun 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djkonro djkonro Awaiting requested review from djkonro

Assignees

@djkonro djkonro

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pokoli @sebgoa @mbohlool @djkonro @k8s-ci-robot