Rest: Warn about swallowed _request_timeout

[sbrandtb]

If _request_timeout is neither an int, nor a 2-tuple, it is swallowed without further notice which is a rather unfortunate because the level developers would have to look for this issue is pretty deep.

This actually leads to confusion already, see apache/airflow#6643 (comment)

While it would break backwards compatibility to raise an exception, we should at least warn the developer.

This is meant as kind of a discussion base. I am not fully aware of how you developers would like to deal with this. Feedback appreciated 🙂

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @sbrandtb!

It looks like this is your first PR to kubernetes-client/python 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-client/python has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sbrandtb
To complete the pull request process, please assign yliaog
You can assign the PR to them by writing /assign @yliaog in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbrandtb]

I am working on the CLA...

[sbrandtb]

/check-cla

[sbrandtb]

/retest

[k8s-ci-robot]

@sbrandtb: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbrandtb]

/check-cla

[micw523]

This issue is probably better filed upstream, since this file is automatically generated.

[roycaihw]

I agree with @micw523. This file is generated by https://github.com/openapitools/openapi-generator. The discussion and change fit better there.

/close

[k8s-ci-robot]

@roycaihw: Closed this PR.

In response to this:

I agree with @micw523. This file is generated by https://github.com/openapitools/openapi-generator. The discussion and change fit better there.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cjgibson]

For those that stumble across this issue in the near future, this root issue here is resolved within https://github.com/openapitools/openapi-generator and the fix will be released alongside their upcoming 5.0.0 release. In the interim, you can fix this (somewhat easily) by opting to pass a (connection, read) timeout tuple instead of a bare timeout integer. E.g.:

>>> from kubernetes.client.configuration import Configuration
>>> from kubernetes.client.rest import RESTClientObject
>>> rest_client_object = RESTClientObject(Configuration())
>>> impossible_timeout = 1e-10  # seconds, light travels ~3 cm
>>>
>>> # will ignore the provided timeout
>>> rest_client_object.request('GET', 'http://neverssl.com', _request_timeout=impossible_timeout)
<kubernetes.client.rest.RESTResponse object at 0x7f9c03cfff90>
>>>
>>> # will respect the provided timeout
>>> rest_client_object.request('GET', 'http://neverssl.com', _request_timeout=(
...     0.1 * impossible_timeout, 0.9 * impossible_timeout))
Traceback (most recent call last):
socket.timeout: timed out

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
urllib3.exceptions.ConnectTimeoutError: (<urllib3.connection.HTTPConnection object at 0x7f9c03e20410>, 'Connection to neverssl.com timed out. (connect timeout=1.0000000000000001e-11)')

During handling of the above exception, another exception occurred:
Traceback (most recent call last):
urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='neverssl.com', port=80): Max retries exceeded with url: / (Caused by ConnectTimeoutError(<urllib3.connection.HTTPConnection object at 0x7f9c03e20410>, 'Connection to neverssl.com timed out. (connect timeout=1.0000000000000001e-11)'))

I actually ended up isolating the problem on my end before finding this issue here, so search keywords to aid the all mighty Googs: Kubernetes doesn't timeout, ignores timeout, never times out, hangs on network, waits for network