Question before implementing PR regarding keep-alive connections

[lalo]

I'm interested in adding a config to enable keep-alive on the connections with urllib3 connection pools. I see that this dependency is brought by the swagger-codegen -> https://github.com/kubernetes-client/python/blob/master/kubernetes/client/configuration.py#L43

If I contribute this to the swagger-codegen project, this project actively moves the dependency to the latest right? Also, is this the right approach or am I missing something else?

Thanks

[tomplus]

Hi. We are moving from swagger-codegen to openapi-generator. You can track it here: kubernetes-client/gen#93. It'd be better to add this feature to openapi-generator.

[wing328]

@lalo May I know if you've time to submit a PR for OpenAPI Generator to enable keep-alive in the Python client?

[lalo]

If it's urgent you should go ahead and implement it, if not I have some personal time constraints and can't prioritize this high enough (maybe in a week or 2).

[wing328]

Please take your time and let us know if you need help with the PR. Thanks for your contribution in advance.

[lalo]

After taking a second look, it seems that there is no need to modify OpenApi generator, since the request method already has a way to modify the headers.

python/kubernetes/client/rest.py

Line 118 in 6d4587e

:param headers: http request headers

My take is that we should/could be able to set it to 'connection': 'keep-alive', thoughts?

[wing328]

@lalo Sure, we can use this method for the time being.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.