Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRD's don't have dry_run option #1165

Closed
sniranjan opened this issue May 10, 2020 · 8 comments
Closed

CRD's don't have dry_run option #1165

sniranjan opened this issue May 10, 2020 · 8 comments
Assignees

Comments

@sniranjan
Copy link

sniranjan commented May 10, 2020

While working with CRDs (create/patch/delete), there is no dry_run option similar to the other native objects.

API Call for creating a custom object

api_instance.create_namespaced_custom_object(group, version, namespace, plural, body, pretty=pretty)
Reference - create_namespaced_custom_object

API Call for Deployment

api_instance.create_namespaced_deployment(namespace, body, pretty=pretty, dry_run=dry_run, field_manager=field_manager)

Is there any workaround to this?

@palnabarun
Copy link
Member

Hi @sniranjan, the support for dry-run to CRD's has recently been added (kubernetes-client/gen#154). Whenever the next client version is generated, it would get updated.

/assign

@LouisPlisso
Copy link

Hi @palnabarun , when can we expect the next version of the client? It's currently blocking us for the dry-run feature
Thanks

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 13, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Oct 13, 2020
@palnabarun
Copy link
Member

@sniranjan @LouisPlisso -- with #1280, this feature would come to the latest stable client release. Thank you for your patience. 👍

@palnabarun
Copy link
Member

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Oct 14, 2020
@palnabarun
Copy link
Member

This has now been resolved with the latest client release.

/close

@k8s-ci-robot
Copy link
Contributor

@palnabarun: Closing this issue.

In response to this:

This has now been resolved with the latest client release.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants