Skip to content
This repository has been archived by the owner on Mar 13, 2022. It is now read-only.

Conversation

roycaihw
Copy link
Member

Cherry pick of #79 on release-8.0-base64-patch.

#79: Fix base64 padding for kube config

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2019
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 30, 2019
@yliaog
Copy link
Contributor

yliaog commented Jul 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 30, 2019
@yliaog
Copy link
Contributor

yliaog commented Jul 30, 2019

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roycaihw, yliaog

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roycaihw
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2019
@roycaihw roycaihw force-pushed the automated-cherry-pick-of-#79-upstream-release-8.0-base64-patch branch from ea81ab5 to d492cd3 Compare July 30, 2019 21:13
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@micw523
Copy link
Contributor

micw523 commented Jul 30, 2019

@roycaihw Might need to REVERT commit 2f3247b #100 on the branch

@codecov-io
Copy link

Codecov Report

Merging #147 into release-8.0-base64-patch will increase coverage by 0.02%.
The diff coverage is 86.95%.

Impacted file tree graph

@@                     Coverage Diff                      @@
##           release-8.0-base64-patch     #147      +/-   ##
============================================================
+ Coverage                     92.04%   92.07%   +0.02%     
============================================================
  Files                            13       13              
  Lines                          1182     1199      +17     
============================================================
+ Hits                           1088     1104      +16     
- Misses                           94       95       +1
Impacted Files Coverage Δ
config/kube_config_test.py 94.55% <100%> (+0.13%) ⬆️
config/kube_config.py 84.27% <66.66%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c242ea...4017a9d. Read the comment docs.

@roycaihw roycaihw added lgtm Indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 30, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3f6e65b into kubernetes-client:release-8.0-base64-patch Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants