This repository has been archived by the owner on Mar 13, 2022. It is now read-only.
Ensure no base64 incorrect padding errors occur in PY3 #132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a Kubernetes oid token configuration with Python 3, I encountered incorrect padding errors when the library attempted to decode the base64 string. Looking into the code base, I noticed that == is added to avoid this error in Python 2, but is mysteriously omitted from the Python 3 call.
I'm not sure why this is, especially since Python 3 has the exact same behaviour regarding insufficient padding as Python 2. Since the trick with adding == still works in Python 3, I have simply copied this from the Python 2 implementation and added a comment why this magic constant works.