-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-generate CustomObjectApi to support pagination #742
Re-generate CustomObjectApi to support pagination #742
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yue9944882 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c1cd5d4
to
36ad788
Compare
This is a breaking change (albeit a small one) how do we feel about things like this? Also, can you separate the build-fix PR into a different PR |
42b065f
to
36ad788
Compare
SGTM, separated |
closing and reopen to trigger travis. |
@yue9944882 what do you think about the fact that this is a breaking change? |
@brendandburns are you suggesting we should merging this together w/ #709? instead of one dedicated pull? |
I think we should move to OpenAPI generator as part of the Or at the very least, if we're going to make this change, I think we should rev. to |
for the record, 7.0.0 aligns w/ 1.15 release of k/k. or are we deciding skipping 1.15?
+1 on your concern about the compatibility, since this pull is tweaking public interfaces. i think the openapi-generator pull is taking off soon. closing this in favor of the migration pull. |
regenerate by following the instrcutions from kubernetes-client/gen