Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate CustomObjectApi to support pagination #742

Conversation

yue9944882
Copy link
Member

regenerate by following the instrcutions from kubernetes-client/gen

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yue9944882

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2019
@yue9944882
Copy link
Member Author

@brendandburns
Copy link
Contributor

This is a breaking change (albeit a small one) how do we feel about things like this?

Also, can you separate the build-fix PR into a different PR

@yue9944882
Copy link
Member Author

SGTM, separated

@brendandburns
Copy link
Contributor

closing and reopen to trigger travis.

@brendandburns
Copy link
Contributor

@yue9944882 what do you think about the fact that this is a breaking change?

@yue9944882
Copy link
Member Author

@brendandburns are you suggesting we should merging this together w/ #709? instead of one dedicated pull?

@brendandburns
Copy link
Contributor

I think we should move to OpenAPI generator as part of the 7.0.0 (kubernetes 1.16.x) release...

Or at the very least, if we're going to make this change, I think we should rev. to 6.1.x to indicate that it's a bigger change than just bug fixes...

@yue9944882
Copy link
Member Author

I think we should move to OpenAPI generator as part of the 7.0.0 (kubernetes 1.16.x) release...

for the record, 7.0.0 aligns w/ 1.15 release of k/k. or are we deciding skipping 1.15?

Or at the very least, if we're going to make this change, I think we should rev. to 6.1.x to indicate that it's a bigger change than just bug fixes...

+1 on your concern about the compatibility, since this pull is tweaking public interfaces. i think the openapi-generator pull is taking off soon. closing this in favor of the migration pull.

@yue9944882 yue9944882 closed this Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants