Rev to version 1.13 #23
Conversation
|
is there any manual change? probably nice to add the command you run to generate the files in the PR, so it can be easily repeated, and verified. |
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
@yliaog Split this up into human intervention and boilerplate PRs... Thanks! |
| | client 0.1.0a1 | ✓ | | ||
| |------------------|-----------------|-----------------| |
There was a problem hiding this comment.
when click on 'View file', i see -------------------- row in the matrix, is it intentional?
kubernetes/settings
Outdated
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Copyright 2015 The Kubernetes Authors. | |||
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
so this is a bash script, it's better to name the file as xxxx.sh?
There was a problem hiding this comment.
settings is consistent with both the instructions in the gen repo and the other client repos...
| @@ -26,7 +26,7 @@ This endpoint does not need any parameter. | |||
|
|
|||
| ### HTTP request headers | |||
|
|
|||
| - **Content-Type**: application/json, application/yaml, application/vnd.kubernetes.protobuf | |||
| - **Content-Type**: Not defined | |||
There was a problem hiding this comment.
why is this change? looks suspicious
There was a problem hiding this comment.
These docs are generated. I suspect the Swagger is broken, but I don't think it's worth fixing the swagger for this PR.
| **Kind** | **string** | Kind is a string value representing the REST resource this object represents. Servers may infer this from the endpoint the client submits requests to. Cannot be updated. In CamelCase. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#types-kinds | [optional] [default to null] | ||
| **Metadata** | [***V1ObjectMeta**](v1.ObjectMeta.md) | Standard object metadata. | [optional] [default to null] | ||
| **Spec** | [***AppsV1beta1DeploymentSpec**](apps.v1beta1.DeploymentSpec.md) | Specification of the desired behavior of the Deployment. | [optional] [default to null] | ||
| **Status** | [***AppsV1beta1DeploymentStatus**](apps.v1beta1.DeploymentStatus.md) | Most recently observed status of the Deployment. | [optional] [default to null] |
There was a problem hiding this comment.
so the description is removed, any idea what's the reason for that?
|
Comments (mostly) addressed, please re-check. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, yliaog The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@mbohlool @roycaihw