Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch ruby client to use openapi-generator #103

Conversation

ackintosh
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 18, 2019
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
  • If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 18, 2019
@ackintosh
Copy link
Contributor Author

There're hand-written test codes in spec folder, which is deleted on regeneration.

The hand-written tests is deleted on re-generation · Issue #29 · kubernetes-client/ruby

@brendandburns brendandburns reopened this Feb 25, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 25, 2019
@brendandburns
Copy link
Contributor

close/re-open to trigger CLA bot.

@ackintosh thanks for doing this. I LGTM'd your other PR.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ackintosh, brendandburns

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2019
@ackintosh ackintosh changed the title [WIP] Switch ruby client to use openapi-generator Switch ruby client to use openapi-generator Feb 26, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2019
@ackintosh
Copy link
Contributor Author

@brendandburns Thanks for your merging. I'll file a PR to kubernetes-client/ruby to update the client.

@cjwagner
Copy link

/hold
Holding this PR because it is a draft PR and is causing problems with Tide.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2019
@brendandburns
Copy link
Contributor

@ackintosh can you remove the 'draft' label?

Thanks!

@ackintosh ackintosh marked this pull request as ready for review March 6, 2019 11:15
@ackintosh
Copy link
Contributor Author

Thanks for notifying me! Made this PR to ready.

@brendandburns brendandburns removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit 17c4c90 into kubernetes-client:master Mar 16, 2019
@ackintosh ackintosh deleted the switch-ruby-client-to-use-openapi-generator branch March 17, 2019 00:31
@ackintosh
Copy link
Contributor Author

Thanks for merging this PR. As a next step to migrate to openapi-generator, I'll file a PR to kubernetes-client/ruby in order to update the Ruby client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants