-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch ruby client to use openapi-generator #103
Switch ruby client to use openapi-generator #103
Conversation
ackintosh
commented
Feb 18, 2019
- Related issue : migrate from swagger-codegen to openapi-generator #93
- Similar PR on the python client : feat: switch python client to use openapi-generator #97
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There're hand-written test codes in The hand-written tests is deleted on re-generation · Issue #29 · kubernetes-client/ruby |
close/re-open to trigger CLA bot. @ackintosh thanks for doing this. I LGTM'd your other PR. /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ackintosh, brendandburns The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@brendandburns Thanks for your merging. I'll file a PR to kubernetes-client/ruby to update the client. |
/hold |
@ackintosh can you remove the 'draft' label? Thanks! |
Thanks for notifying me! Made this PR to ready. |
Thanks for merging this PR. As a next step to migrate to openapi-generator, I'll file a PR to kubernetes-client/ruby in order to update the Ruby client. |