Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to .NET Core SDK 3.1. #395

Merged
merged 6 commits into from
Apr 6, 2020
Merged

Upgrade to .NET Core SDK 3.1. #395

merged 6 commits into from
Apr 6, 2020

Conversation

andykernahan
Copy link
Contributor

As discussed in #386 and #389, this PR upgrades to .NET Core SDK 3.1. It also installs the requisite 2.0.9 & 2.1.17 runtimes:

  • The GitHub actions specify the SDK version and SDK 2.1.202 / 2.1.805 include runtime 2.0.9 / 2.1.17 respectively.
  • The Travis linux and osx scripts install the runtimes directly as there is no APT package for SDK 2.1.805; I thought it best to keep those environments as similar as possible.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: andykernahan
To complete the pull request process, please assign krabhishek8260
You can assign the PR to them by writing /assign @krabhishek8260 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 1, 2020
@andykernahan
Copy link
Contributor Author

The GitHub builds are failing as setup-dotnet does not support side by side installations (see actions/setup-dotnet#25). I will apply the workaround described in that issue.

@tg123
Copy link
Member

tg123 commented Apr 1, 2020

I think we can remove travis ci totally
there is still an integration test in it built on top of minikube.
I was doing so but did not finish
cc @brendanburns

sorry did not feel good these days, response slowly .

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 3, 2020
@andykernahan andykernahan force-pushed the upgrade-sdk branch 3 times, most recently from b369405 to 7adfee2 Compare April 3, 2020 10:48
@andykernahan
Copy link
Contributor Author

Apologies for the churn.

The Windows build is now failing expectedly due to #389. Once that is merged I will rebase.

tg123
tg123 approved these changes Apr 3, 2020
View reviewed changes
.github/workflows/dotnet.yaml
- name: Setup SxS dotnet
if: matrix.os == 'windows-latest'
run: |
(robocopy %DOTNET_ROOT:3.1.201=2.1.805% %DOTNET_ROOT% /E /XC /XN /XO /NFL /NDL /NJH /NJS /NP) ^& if %ERRORLEVEL% geq 8 exit /B %ERRORLEVEL%
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol
maybe powershell is a better choice

install-osx.sh
@@ -1,9 +1,13 @@
#!/bin/sh
echo 'Installing .NET Core...'

wget https://download.visualstudio.microsoft.com/download/pr/4850aa8f-44a9-4c4a-9961-f18aa4d90ceb/07d790444f3ba6b412a76d6f1aced338/dotnet-sdk-2.2.105-osx-x64.pkg -O ~/dotnet-sdk-2.2.105-osx-x64.pkg
wget https://download.microsoft.com/download/3/a/3/3a3bda26-560d-4d8e-922e-6f6bc4553a84/dotnet-runtime-2.0.9-osx-x64.pkg -O ~/dotnet-runtime-2.0.9-osx-x64.pkg
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brendanburns did you remove travis from this repo?
I did not see it triggered anymore

I mean we can remove those files for travis if no longer used

@brendandburns
Copy link
Contributor

We can definitely remove Travis. Lets do that in a different PR.

I'm ok to merge this, @tg123 any last comments?

@tg123 tg123 merged commit 944622d into kubernetes-client:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tg123 tg123 tg123 approved these changes

@brendandburns brendandburns Awaiting requested review from brendandburns

@krabhishek8260 krabhishek8260 Awaiting requested review from krabhishek8260

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andykernahan @k8s-ci-robot @tg123 @brendandburns