-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add KubernetesClient.Aot to support Aot #1498
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1498 +/- ##
=========================================
Coverage ? 70.46%
=========================================
Files ? 89
Lines ? 2641
Branches ? 552
=========================================
Hits ? 1861
Misses ? 780
Partials ? 0 ☔ View full report in Codecov by Sentry. |
@tg123 I hope you will succeed :) I'am waiting a lot for this awesome PullRequest :) |
i am also working on making watch for aot |
I need a |
lets merge first and get nuget from github action |
@tg123 it would be awesome :) |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
</ItemGroup> | ||
|
||
<ItemGroup> | ||
<Reference Include="System.Net.Http" Condition="'$(TargetFramework)' == 'net48'" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seemed this can be removed since we target for net8.0
only for this project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, copy paste issue, will fix it
Thank you @tg123 will test it today :) |
@guillaume-chervet thank you |
#1395
the main project cannot support aot due to dependencies or some dynamic requirements, for example crd json/yaml serialization
the solution now is doing the same as
.Classic
, to create a separate project, trim aot non friendly featuresKnown unsupported features
@brendanburns please also register
KubernetesClient.Aot
to nuget.org