-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adopt newer source generator #1417
Conversation
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #1417 +/- ##
=========================================
Coverage ? 70.50%
=========================================
Files ? 89
Lines ? 2648
Branches ? 0
=========================================
Hits ? 1867
Misses ? 781
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Generally looks good, some comments on some dead code/config |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brendandburns, tg123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
hi @tg123 , When i use trimming with latest version I obtain at runtime: |
@guillaume-chervet aot is not fully ready, i am still working on it. |
I have that with trimming mode in .net8.0. |
Is it possible to annotate method with DynamicallyAccessedMembers attribute to make library buildable with trimming activated? |
I think merging #1311 will unblock folks until the final solution is done. |
use new https://github.com/dotnet/roslyn/blob/main/docs/features/incremental-generators.md to generate client code
now generated model code could work together with json source generator (aot requirement)