Support KubeOVN VPC and Subnet #1863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
kind/feature
moadqassem
force-pushed
the
support-kubeovn-vpc-subnet
branch
from
de8fc52
to
89263ae
Compare
yaa110
requested changes
Oct 8, 2024
| @@ -1105,3 +1104,33 @@ func setOVNAnnotations(c *Config, annotations map[string]string) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| func validateProviderNetwork(config *Config, providerNetwork *kubevirttypes.ProviderNetwork) error { | |||
There was a problem hiding this comment.
The function's name doesn't reflect its behavior; while it implies that it performs validation, it actually mutates data.
|
/approve |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yaa110 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
approved
|
LGTM label has been added. Git tree hash: 699d1f21434a01a3ef77b1f4c69a1236b21170c9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for KubeOVN subnet and VPC in kubevirt provider.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: