Support topology aware zones and regions in KubeVirt #1860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubermatic-bot
added
dco-signoff: yes
moadqassem
changed the title
kubermatic-bot
added
size/M
moadqassem
force-pushed
the
support-storage-topology
branch
from
e6b0f4b to
e7ba964
Compare
kubermatic-bot
added
size/L
moadqassem
force-pushed
the
support-storage-topology
branch
from
0d316f1 to
2493ab9
Compare
moadqassem
changed the title
yaa110
requested changes
Sep 26, 2024
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yaa110 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
/lgtm |
|
LGTM label has been added. Git tree hash: 5cc0934c2a81c1b586c4c7d7fd737135a35b30cd
|
yaa110
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support for the two labels
topology.kubernetes.io/regionandtopology.kubernetes.io/zonelabels where they can deployed on both Node level(The kubelet or the external cloud-controller-manager populates this with the information from the cloud provider) and on PVC level(topology-aware volume provisioners will automatically set node affinity constraints on a PersistentVolume.).A zone represents a logical failure domain. It is common for Kubernetes clusters to span multiple zones for increased availability and a region represents a larger domain, made up of one or more zones.
Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind feature
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: