Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move module to k8c.io/machine-controller #1842

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Move module to k8c.io/machine-controller #1842

merged 1 commit into from
Aug 26, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 15, 2024

What this PR does / why we need it:

Move the machine-controller module from github.com/kubermatic/machine-controller to k8c.io/machine-controller. We have done this a long time ago for other projects, but machine-controller had some technical blockers. Those blockers got resolved along the way, and now we can finally proceed with this change.

What type of PR is this?

/kind feature
/kind api-change

Does this PR introduce a user-facing change? Then add your Release Note here:

[ACTION REQUIRED] Move the machine-controller Go module from `github.com/kubermatic/machine-controller` to `k8c.io/machine-controller`. If you're using machine-controller types or packages, you'll have to update your code to use `k8c.io/machine-controller`.

Documentation:

NONE

/assign @xrstf
/hold requires infra changes

@xmudrii xmudrii requested a review from xrstf August 15, 2024 15:00
@kubermatic-bot kubermatic-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 15, 2024
@xmudrii
Copy link
Member Author

xmudrii commented Aug 15, 2024

/test pull-machine-controller-e2e-kubevirt

@xmudrii
Copy link
Member Author

xmudrii commented Aug 19, 2024

/test pull-machine-controller-e2e-hetzner
/test pull-machine-controller-e2e-vmware-cloud-director

@xmudrii
Copy link
Member Author

xmudrii commented Aug 22, 2024

/test pull-machine-controller-e2e-azure
/test pull-machine-controller-e2e-vmware-cloud-director

@xmudrii
Copy link
Member Author

xmudrii commented Aug 22, 2024

/test pull-machine-controller-e2e-azure

@xmudrii
Copy link
Member Author

xmudrii commented Aug 23, 2024

/test pull-machine-controller-e2e-vmware-cloud-director

@xmudrii
Copy link
Member Author

xmudrii commented Aug 26, 2024

/test pull-machine-controller-e2e-azure

@xrstf
Copy link
Contributor

xrstf commented Aug 26, 2024

/override pull-machine-controller-e2e-kubevirt

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-kubevirt

In response to this:

/override pull-machine-controller-e2e-kubevirt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrstf
Copy link
Contributor

xrstf commented Aug 26, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ce40848c1485206b438981616275490b6acec38c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2024
@xrstf
Copy link
Contributor

xrstf commented Aug 26, 2024

/override pull-machine-controller-e2e-azure no RHEL sub anymore
/override pull-machine-controller-e2e-vmware-cloud-director capacity issues

@kubermatic-bot
Copy link
Contributor

@xrstf: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • RHEL
  • anymore
  • capacity
  • issues
  • no
  • sub

Only the following failed contexts/checkruns were expected:

  • pull-kubermatic-machine-controller-validate-prow-yaml
  • pull-machine-controller-build
  • pull-machine-controller-dependencies
  • pull-machine-controller-e2e-azure
  • pull-machine-controller-e2e-azure-custom-image-reference
  • pull-machine-controller-e2e-custom-ca
  • pull-machine-controller-e2e-digitalocean
  • pull-machine-controller-e2e-equinix-metal
  • pull-machine-controller-e2e-gce
  • pull-machine-controller-e2e-hetzner
  • pull-machine-controller-e2e-invalid-objects-get-rejected
  • pull-machine-controller-e2e-kubevirt
  • pull-machine-controller-e2e-nutanix
  • pull-machine-controller-e2e-vmware-cloud-director
  • pull-machine-controller-e2e-vsphere
  • pull-machine-controller-license-validation
  • pull-machine-controller-lint
  • pull-machine-controller-test
  • pull-machine-controller-verify-boilerplate
  • pull-machine-controller-yamllint
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override pull-machine-controller-e2e-azure no RHEL sub anymore
/override pull-machine-controller-e2e-vmware-cloud-director capacity issues

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xrstf
Copy link
Contributor

xrstf commented Aug 26, 2024

/override pull-machine-controller-e2e-azure
/override pull-machine-controller-e2e-vmware-cloud-director

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure, pull-machine-controller-e2e-vmware-cloud-director

In response to this:

/override pull-machine-controller-e2e-azure
/override pull-machine-controller-e2e-vmware-cloud-director

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 26, 2024

/hold cancel
:shipit:

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 26, 2024
@kubermatic-bot kubermatic-bot merged commit 7051af1 into kubermatic:main Aug 26, 2024
22 checks passed
@xmudrii xmudrii deleted the k8c-io-mc branch August 26, 2024 13:49
@xmudrii xmudrii mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@xrstf xrstf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @xrstf @kubermatic-bot