Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS: Increase HttpPutResponseHopLimit to 3 for EC2 instances #1833

Merged
merged 1 commit into from
Jul 31, 2024
Merged

AWS: Increase HttpPutResponseHopLimit to 3 for EC2 instances #1833

merged 1 commit into from
Jul 31, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jul 31, 2024 •
edited
Loading

What this PR does / why we need it:
The latest Ubuntu 22.04 images have IMDSv2 enabled as a default. By default, the limit of hops of PUT requests to metadata service is 2. The instance metadata service is not reachable from the container network in case if further hops are required.

We came across this issue while working with Cilium as CNI. The issue has been documented here.

Although, the issue mentions a workaround to make it work with Cilium. Fixing it just for a single component is not ideal since a tool like machine-controller shouldn't judge how the underlying network or programs hosted on the machines provisioned by it are configured. Hence, we went with a more generic fix for this, i.e. to set the HTTP PUT response hop limit to 3. This ensures a much wider compatibility.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

AWS: Increase HttpPutResponseHopLimit to 3 for EC2 instances

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. docs/none Denotes a PR that doesn't need documentation (changes). and removed do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. labels Jul 31, 2024
xmudrii
xmudrii approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f0d4cbc8fa9ea768195399ca21b9591af6149c8c

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2024
@xmudrii
Copy link
Member

xmudrii commented Jul 31, 2024

/hold
Looks like we don't run AWS tests by default in MC, let me quickly check this

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@xmudrii
Copy link
Member

xmudrii commented Jul 31, 2024

/test pull-machine-controller-e2e-aws
/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2024
@xmudrii
Copy link
Member

xmudrii commented Jul 31, 2024

/retest

@kubermatic-bot kubermatic-bot merged commit 5349a3c into kubermatic:main Jul 31, 2024
13 checks passed
@xrstf xrstf mentioned this pull request Jul 31, 2024
Closed
@ahmedwaleedmalik ahmedwaleedmalik deleted the aws-increase-hops branch July 31, 2024 16:59
@xrstf xrstf mentioned this pull request Jul 31, 2024
Merged
xrstf pushed a commit to xrstf/machine-controller that referenced this pull request Jul 31, 2024
@ahmedwaleedmalik @xrstf
[release/v1.59] AWS: Increase IMDS hop limit for EC2 instances (kuber…
68124e7 
…matic#1833)

Signed-off-by: Waleed Malik <[email protected]>
@xrstf
Copy link
Contributor

xrstf commented Jul 31, 2024

/cherrypick release/v1.59

@xrstf
Copy link
Contributor

xrstf commented Jul 31, 2024

/cherrypick release/v1.58

@xrstf
Copy link
Contributor

xrstf commented Jul 31, 2024

/cherrypick release/v1.57

@kubermatic-bot kubermatic-bot mentioned this pull request Jul 31, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #1834

In response to this:

/cherrypick release/v1.59

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #1835

In response to this:

/cherrypick release/v1.58

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot
Copy link
Contributor

@xrstf: new pull request created: #1836

In response to this:

/cherrypick release/v1.57

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Jul 31, 2024
Merged
Merged
@archups archups mentioned this pull request Aug 5, 2024
Merged
@toschneck toschneck mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedwaleedmalik @kubermatic-bot @xmudrii @xrstf