Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStack: Support enabling config drive #1829

Merged
merged 1 commit into from
Jul 23, 2024
Merged

OpenStack: Support enabling config drive #1829

merged 1 commit into from
Jul 23, 2024

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:
This adds support for enabling config drive for OpenStack VMs. When enabled, metadata for machines is stored on a configuration drive instead of the metadata service.

Which issue(s) this PR fixes:

Towards kubermatic/kubermatic#13618

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

OpenStack: Support enabling config drive

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik requested a review from kron4eg July 23, 2024 12:57
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jul 23, 2024
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 23, 2024
@ahmedwaleedmalik ahmedwaleedmalik force-pushed the openstack-config-drive branch from b9c8814 to baa5e99 Compare July 23, 2024 13:13
@ahmedwaleedmalik ahmedwaleedmalik force-pushed the openstack-config-drive branch from baa5e99 to 2ea02fb Compare July 23, 2024 13:14
@judge-red judge-red mentioned this pull request Aug 22, 2024
Closed
@xrstf
Copy link
Contributor

xrstf commented Jul 23, 2024

/override pull-machine-controller-e2e-gce

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-gce

In response to this:

/override pull-machine-controller-e2e-gce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kron4eg
Copy link
Member

kron4eg commented Jul 23, 2024

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9f806bef1ecd6dbefd869c93d08b033f7ad65788

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2024
@kubermatic-bot kubermatic-bot merged commit b030806 into kubermatic:main Jul 23, 2024
12 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the openstack-config-drive branch July 23, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ahmedwaleedmalik @xrstf @kubermatic-bot @kron4eg