Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.57] Update AMI filter for rocky linux (#1803) / Bump OSM to 1.3.6 #1807

Merged
merged 2 commits into from
Jun 5, 2024
Merged

[release/v1.57] Update AMI filter for rocky linux (#1803) / Bump OSM to 1.3.6 #1807

merged 2 commits into from
Jun 5, 2024

Conversation

xrstf
Copy link
Contributor

@xrstf xrstf commented Jun 5, 2024

What this PR does / why we need it:
This is a manual backport of #1803.

What type of PR is this?
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Update AWS AMI filter for rocky linux 8

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/chore Updating grunt tasks etc; no production code changes. labels Jun 5, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2024
@xrstf xrstf marked this pull request as ready for review June 5, 2024 14:05
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 5, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@ahmedwaleedmalik
Copy link
Member

@xrstf https://github.com/kubermatic/machine-controller/blob/release/v1.57/examples/operating-system-manager.yaml#L1321

s/v1.3.4/v1.3.6

@ahmedwaleedmalik
Copy link
Member

/lgtm cancel

To avoid retries

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 5, 2024
@xrstf xrstf changed the title [release/v1.57] Update AMI filter for rocky linux (#1803) [release/v1.57] Update AMI filter for rocky linux (#1803) / Bump OSM to 1.3.6 Jun 5, 2024
@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8cfd7ebaae7f74251e4c2de1be2c3810076cf5c1

@kubermatic-bot kubermatic-bot merged commit 1b8f3f7 into kubermatic:release/v1.57 Jun 5, 2024
17 checks passed
This was referenced Jun 6, 2024
Merged
Merged
Merged
@xrstf xrstf deleted the backport-1803-1.57 branch July 31, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xrstf @kubermatic-bot @ahmedwaleedmalik