-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove user-data plugins from machine-controller #1789
Remove user-data plugins from machine-controller #1789
Conversation
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
@xrstf pull-machine-controller-e2e-vsphere, pull-machine-controller-e2e-azure-custom-image-reference needs to be overridden. Maybe in the future, we can run these tests periodically, once a day, so that we are more aware of issues like kubermatic/operating-system-manager#381 and generally failing tests like pull-machine-controller-e2e-azure-custom-image-reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOVE IT!
small change proposed
Signed-off-by: Waleed Malik <[email protected]>
/approve |
LGTM label has been added. Git tree hash: 081522b2ad4b314ff3be7fc7dfe94316ae16727a
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm cancel there is failing linter job |
Signed-off-by: Waleed Malik <[email protected]>
Should be fixed now, even more cleanup :D |
/lgtm |
LGTM label has been added. Git tree hash: 70398970b434ded79958a79173597d5a4f2d4de8
|
/override pull-machine-controller-e2e-azure |
@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-azure, pull-machine-controller-e2e-azure-custom-image-reference, pull-machine-controller-e2e-vsphere In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
User data plugins from machine-controller have been removed in favor of OSM.
What this PR does / why we need it:
Historically, machine-controller relied on user data plugins to generate configurations(cloud-config) for worker machines. Each operating system requires its own user-data plugin. These configs are then injected into the worker nodes using provisioning utilities such as cloud-init or ignition. Eventually, the nodes are bootstrapped.
Over time, it has been observed that this workflow has certain limitations.
ubuntu
.user-data
, machine won't be created in case of non-compliance. For example, at the time of writing this, AWS has set a hard limit of 16KB.To overcome these limitations; Kubermatic built Operating System Manager a few years ago. Please refer to Operating System Manager for more details.
These plugins were deprecated about a year ago in #1642.
User data plugins from machine-controller have been removed in favor of OSM.
Which issue(s) this PR fixes:
Fixes #1788
What type of PR is this?
/kind cleanup
Special notes for your reviewer:
There will be a follow-up PR with some more cleanup, moving things around from MC to OSM. But since it requires changes in OSM first, we'll do it later in another PR.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: