Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Go 1.22 #1759

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Conversation

ahmedwaleedmalik
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind chore

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

machine-controller is now built using Go 1.22

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Feb 9, 2024
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/chore Updating grunt tasks etc; no production code changes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 9, 2024
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Copy link
Contributor

@xrstf xrstf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f5cfa1a44bade194e401d6bb34535c92dcdacd3a

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrstf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2024
@kubermatic-bot kubermatic-bot merged commit 938522f into kubermatic:main Feb 9, 2024
15 checks passed
@ahmedwaleedmalik ahmedwaleedmalik deleted the go-1.22 branch February 9, 2024 10:10
nrobert13 pushed a commit to syseleven/machine-controller that referenced this pull request Feb 21, 2024
* Upgrade to Go 1.22

Signed-off-by: Waleed Malik <[email protected]>

* Upgrade CRDs for OSM

Signed-off-by: Waleed Malik <[email protected]>

---------

Signed-off-by: Waleed Malik <[email protected]>
ovstuckrad pushed a commit to syseleven/machine-controller that referenced this pull request Feb 21, 2024
* Bump go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc (kubermatic#1731)

Bumps [go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc](https://github.com/open-telemetry/opentelemetry-go-contrib) from 0.42.0 to 0.46.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go-contrib/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go-contrib@zpages/v0.42.0...zpages/v0.46.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Migrate to dl.k8s.io from kubernetes release bucket (kubermatic#1737)

Signed-off-by: Waleed Malik <[email protected]>

* Flatcar Support for GCE (kubermatic#1739)

* Flatcar Support for GCE

Signed-off-by: Waleed Malik <[email protected]>

* Update compatibility matrix

Signed-off-by: Waleed Malik <[email protected]>

---------

Signed-off-by: Waleed Malik <[email protected]>

* Update Prow jobs to build image with Go 1.21.5 (kubermatic#1746)

* Update Prow jobs to build image with Go 1.21.5

Signed-off-by: Marvin Beckers <[email protected]>

* Also update golang images

Signed-off-by: Marvin Beckers <[email protected]>

* Also update Dockerfile and Makefile

Signed-off-by: Marvin Beckers <[email protected]>

* Update OSM flags

Signed-off-by: Marvin Beckers <[email protected]>

* Use fixed build image

Signed-off-by: Marvin Beckers <[email protected]>

* ???

Signed-off-by: Marvin Beckers <[email protected]>

---------

Signed-off-by: Marvin Beckers <[email protected]>

* Deprecate sig-virtualization (kubermatic#1749)

with merge of sig-virtualization into sig-cluster-management, there is no need for standalone OWNERS hierarchy for kubevirt

Signed-off-by: Jan Wozniak <[email protected]>

* kubevirt: allow setting storage volume access types (kubermatic#1740)

this is important for live migration because only RWX volumes can be live migrated

Signed-off-by: Jan Wozniak <[email protected]>

* AWS: increase spot instance price (kubermatic#1754)

Signed-off-by: Waleed Malik <[email protected]>

* Adds field to check if a IP reservation is still valid, (kubermatic#1753)

if the IP is no longer valid a new one is requested.

This fixes a bug where we use an IP that expired already for a VM,
if the VM provisioning failed, which then leads to a race condition.
In which we wait for the VM provisioning to finish, but it can't due the IP being no longer useable,
but we also never request a new IP in that case.

Signed-off-by: Zofia hagenguth <[email protected]>

* webhook: refactor to use controller-runtime server (kubermatic#1751)

Refactor the webhook to use the controller-runtime provided
webhook.Server instead of a plain HTTP server. The biggest benefit this
brings, is it automatically loading changed certificate files instead of
forever using the ones present when the server was started.

This could have been implemented by using the controller-runtime
CertWatcher manually, but that would've been more code and aligning
machine-controller with the ecosystem-provided standards seems worth it.

Signed-off-by: Mara Sophie Grosch <[email protected]>

* Support for Kubernetes 1.29 (kubermatic#1755)

* Add support for kubernetes v1.29

Signed-off-by: Waleed Malik <[email protected]>

* Update dependencies and k8s API to v1.29

Signed-off-by: Waleed Malik <[email protected]>

* Enable in-tree providers

Signed-off-by: Waleed Malik <[email protected]>

* Update fixtures

Signed-off-by: Waleed Malik <[email protected]>

* Refactored code

Signed-off-by: Waleed Malik <[email protected]>

---------

Signed-off-by: Waleed Malik <[email protected]>

* Upgrade to Go 1.22 (kubermatic#1759)

* Upgrade to Go 1.22

Signed-off-by: Waleed Malik <[email protected]>

* Upgrade CRDs for OSM

Signed-off-by: Waleed Malik <[email protected]>

---------

Signed-off-by: Waleed Malik <[email protected]>

* Update prow jobs and remove yamllint image (kubermatic#1764)

Signed-off-by: Marvin Beckers <[email protected]>

* Remove TORCX_BINDIR from containerd binary call (kubermatic#1760)

Signed-off-by: Marvin Beckers <[email protected]>

* Support Edge Provider in Machine Controller (kubermatic#1765)

* support edge provider
Signed-off-by: Moath Qasim <[email protected]>

Signed-off-by: Moath Qasim <[email protected]>

* fix linting
Signed-off-by: Moath Qasim <[email protected]>

Signed-off-by: Moath Qasim <[email protected]>

---------

Signed-off-by: Moath Qasim <[email protected]>

* fix syseleven changes

* update fixtures

* update go version in unit tests github workflow

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Waleed Malik <[email protected]>
Signed-off-by: Marvin Beckers <[email protected]>
Signed-off-by: Jan Wozniak <[email protected]>
Signed-off-by: Zofia hagenguth <[email protected]>
Signed-off-by: Mara Sophie Grosch <[email protected]>
Signed-off-by: Moath Qasim <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Waleed Malik <[email protected]>
Co-authored-by: Marvin Beckers <[email protected]>
Co-authored-by: Jan Wozniak <[email protected]>
Co-authored-by: Andromeda <[email protected]>
Co-authored-by: Mara Sophie Grosch <[email protected]>
Co-authored-by: Moath Qasim <[email protected]>
Co-authored-by: Robert Nemeti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/chore Updating grunt tasks etc; no production code changes. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants