[release/v1.54] Fix Flatcar network issues when IPAM is not used #1559
Conversation
Signed-off-by: Marko Mudrinić <[email protected]>
kubermatic-bot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: 80c84527b8d0d041f578f4783c12af5837f1188b
|
kubermatic-bot
added
the
approved
|
/cherry-pick release/v1.55 |
|
@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.55 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
|
|
@embik: once the present PR merges, I will cherry-pick it on top of release/v1.54 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
xmudrii
changed the title
|
/retest Review the full test history Silence the bot with an |
|
/override pull-machine-controller-e2e-vsphere |
|
@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vsphere In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-machine-controller-e2e-vmware-cloud-director |
|
@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vmware-cloud-director In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-machine-controller-e2e-kubevirt |
|
@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-kubevirt In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override pull-machine-controller-e2e-aws-spot-instance |
|
@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-aws-spot-instance In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahmedwaleedmalik: new pull request created: #1560 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
We have an issue where Flatcar nodes are not joining the cluster because the network configuration is broken. This happens only for machines that have
.ProviderSpec.Network.IPFamilyset (e.g. toIPv4). In such case, we try to configure IPAM on that node, however, in many cases IPAM is not used at all. This breaks the network configuration and usually that node doesn't have network connectivity at all.This PR is supposed to fix that issue by configuring IPAM only if IPAM-related parameters are provided. This fix is already present on the
mainbranch.What type of PR is this?
/kind bug
Special notes for your reviewer:
OSM doesn't support IPAM and is not affected by this issue.
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: