Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ID an optional field for vSphere tags #1549

Merged
merged 1 commit into from
Feb 1, 2023
Merged

Make ID an optional field for vSphere tags #1549

merged 1 commit into from
Feb 1, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

Signed-off-by: Waleed Malik [email protected]

What this PR does / why we need it:
Either ID or a combination of Name and Category ID can be used to uniquely determine a tag.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind design

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

VSphere tags can use name or ID as the unique identifier

Documentation:

NONE

@ahmedwaleedmalik
Make ID an optional field for vSphere tags
669796b 
Either ID or a combination of Name and Category ID can be used to uniquely determine a tag

Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Feb 1, 2023
@kubermatic-bot kubermatic-bot added kind/design Categorizes issue or PR as related to design. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 1, 2023
moadqassem
moadqassem approved these changes Feb 1, 2023
View reviewed changes
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7d97867ea112f444ad2f8a4e85fc631b0ac26e06

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,moadqassem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 07702e7 into kubermatic:main Feb 1, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the refactor-tags branch February 1, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moadqassem moadqassem moadqassem approved these changes

Assignees

@moadqassem moadqassem

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/design Categorizes issue or PR as related to design. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedwaleedmalik @kubermatic-bot @moadqassem