Anexia Provider: Return TerminalError on 401 and 403 engine responses

[marioreggiori]

What this PR does / why we need it:
Return TerminalError on 401 and 403 engine responses to signal invalid token configuration.

What type of PR is this?
/kind cleanup

Special notes for your reviewer:
Please cherry-pick to v1.45 and v1.55.

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

[kubermatic-bot]

Hi @marioreggiori. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmedwaleedmalik]

/ok-to-test

[ahmedwaleedmalik]

/cherry-pick release/v1.45

[kubermatic-bot]

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.45 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmedwaleedmalik]

/cherry-pick release/v1.55

[kubermatic-bot]

@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.55 in a new PR and assign it to you.

In response to this:

/cherry-pick release/v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ahmedwaleedmalik]

/approve

[ahmedwaleedmalik]

/lgtm cancel

Lint errors

[ahmedwaleedmalik]

/approve

[kubermatic-bot]

LGTM label has been added.

Git tree hash: cbde07487c9628f91c4bc60dd4b552ed2a6df2b1

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, marioreggiori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/cloudprovider/provider/OWNERS [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kubermatic-bot]

@ahmedwaleedmalik: #1537 failed to apply on top of branch "release/v1.45":

Applying: Anexia Provider: Return TerminalError on 401 and 403 engine responses
Using index info to reconstruct a base tree...
M	pkg/cloudprovider/provider/anexia/provider.go
M	pkg/cloudprovider/provider/anexia/provider_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloudprovider/provider/anexia/provider_test.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/provider/anexia/provider_test.go
Auto-merging pkg/cloudprovider/provider/anexia/provider.go
CONFLICT (content): Merge conflict in pkg/cloudprovider/provider/anexia/provider.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Anexia Provider: Return TerminalError on 401 and 403 engine responses
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release/v1.45

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kubermatic-bot]

@ahmedwaleedmalik: new pull request created: #1539

In response to this:

/cherry-pick release/v1.55

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.