Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.45] Anexia Provider: Utilize Creating state instead of blocking Create call #1536

Merged
merged 1 commit into from
Jan 31, 2023
Merged

[release/v1.45] Anexia Provider: Utilize Creating state instead of blocking Create call #1536

merged 1 commit into from
Jan 31, 2023

Conversation

marioreggiori
Copy link
Contributor

What this PR does / why we need it:

Manual cherry-pick of #1483

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia: Refactor code to reduce provisioning time for node pools with multiple replicas.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2023
@kubermatic-bot
Copy link
Contributor

Hi @marioreggiori. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 23, 2023
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 23, 2023
@ahmedwaleedmalik
Copy link
Member

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 23, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 84177b8f96388680c45a66c47269eb7e5b8289d1

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, marioreggiori

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2023
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2023
@kubermatic-bot
Copy link
Contributor

@marioreggiori: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-deployment-upgrade 1937aa4 link true /test pull-machine-controller-e2e-deployment-upgrade
pull-machine-controller-e2e-ubuntu-upgrade 1937aa4 link true /test pull-machine-controller-e2e-ubuntu-upgrade
pull-machine-controller-e2e-aws-arm 1937aa4 link true /test pull-machine-controller-e2e-aws-arm
pull-machine-controller-e2e-aws-spot-instance 1937aa4 link true /test pull-machine-controller-e2e-aws-spot-instance
pull-machine-controller-e2e-vsphere 1937aa4 link true /test pull-machine-controller-e2e-vsphere
pull-machine-controller-e2e-azure-custom-image-reference 1937aa4 link true /test pull-machine-controller-e2e-azure-custom-image-reference
pull-machine-controller-e2e-hetzner 1937aa4 link true /test pull-machine-controller-e2e-hetzner
pull-machine-controller-e2e-aws 1937aa4 link true /test pull-machine-controller-e2e-aws
pull-machine-controller-e2e-azure 1937aa4 link true /test pull-machine-controller-e2e-azure
pull-machine-controller-e2e-aws-flatcar-containerd 1937aa4 link true /test pull-machine-controller-e2e-aws-flatcar-containerd
pull-machine-controller-e2e-openstack-project-auth 1937aa4 link true /test pull-machine-controller-e2e-openstack-project-auth
pull-machine-controller-e2e-invalid-objects-get-rejected 1937aa4 link true /test pull-machine-controller-e2e-invalid-objects-get-rejected
pull-machine-controller-e2e-custom-ca 1937aa4 link true /test pull-machine-controller-e2e-custom-ca
pull-machine-controller-e2e-gce 1937aa4 link true /test pull-machine-controller-e2e-gce
pull-machine-controller-e2e-aws-ebs-encryption-enabled 1937aa4 link true /test pull-machine-controller-e2e-aws-ebs-encryption-enabled
pull-machine-controller-e2e-openstack 1937aa4 link true /test pull-machine-controller-e2e-openstack
pull-machine-controller-e2e-digitalocean 1937aa4 link true /test pull-machine-controller-e2e-digitalocean
pull-machine-controller-e2e-kubevirt 1937aa4 link true /test pull-machine-controller-e2e-kubevirt

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik ahmedwaleedmalik merged commit e9b48e6 into kubermatic:release/v1.45 Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marioreggiori @kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot