Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cri-tools to v1.26.0 #1535

Merged
merged 3 commits into from
Jan 24, 2023
Merged

Update cri-tools to v1.26.0 #1535

merged 3 commits into from
Jan 24, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jan 20, 2023 •
edited
Loading

What this PR does / why we need it:

Update cri-tools to v1.26.0. This is required for the latest (January 2023) Kubernetes patch releases. This PR also includes an update to the checksum checking for cri-tools: kubermatic/operating-system-manager#258

Reference: kubernetes/release#2821

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Update cri-tools to v1.26.0

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jan 20, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Jan 20, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve 🚀

@kubermatic-bot kubermatic-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 20, 2023
@xmudrii xmudrii marked this pull request as ready for review January 20, 2023 11:58
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@xmudrii xmudrii marked this pull request as draft January 20, 2023 11:58
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@xmudrii
Update cri-tools to v1.26.0
05d301b 
Signed-off-by: Marko Mudrinić <[email protected]>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@xmudrii xmudrii marked this pull request as ready for review January 20, 2023 12:00
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 20, 2023
@ahmedwaleedmalik
Copy link
Member

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@ahmedwaleedmalik
Copy link
Member

/lgtm cancel

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Jan 23, 2023

/test pull-machine-controller-e2e-aws

@xmudrii xmudrii marked this pull request as draft January 23, 2023 16:34
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2023
@ahmedwaleedmalik
Copy link
Member

/test pull-machine-controller-e2e-aws-legacy-userdata

@xmudrii xmudrii marked this pull request as ready for review January 23, 2023 18:05
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 23, 2023
@xmudrii xmudrii requested a review from moadqassem January 23, 2023 18:05
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Jan 23, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b5f661ddc958829b864c1d13ce523aff66880f70

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member Author

xmudrii commented Jan 23, 2023

/retest

2 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented Jan 23, 2023

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Jan 23, 2023

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Jan 23, 2023

/test pull-machine-controller-e2e-openstack

@xmudrii
Copy link
Member Author

xmudrii commented Jan 23, 2023

v1.26 tests for OpenStack are broken (irrelevant to this PR). Kubevirt tests are to be investigated.
/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Jan 24, 2023

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2023
@xrstf
Copy link
Contributor

xrstf commented Jan 24, 2023

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-openstack

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-kubevirt, pull-machine-controller-e2e-openstack

In response to this:

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Jan 24, 2023

/test pull-machine-controller-e2e-aws-arm

@kubermatic-bot kubermatic-bot merged commit 50c8837 into kubermatic:main Jan 24, 2023
@xmudrii xmudrii deleted the cri-tools-1.26.0 branch January 24, 2023 13:40
@xmudrii xmudrii mentioned this pull request Jan 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@moadqassem moadqassem Awaiting requested review from moadqassem

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xmudrii @kubermatic-bot @ahmedwaleedmalik @xrstf