Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for SLES #1525

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Drop support for SLES #1525

merged 1 commit into from
Jan 16, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jan 9, 2023 •
edited
Loading

Signed-off-by: Waleed Malik [email protected]

What this PR does / why we need it:
After much consideration, we have decided to drop support for SLES in favor of other supported and maintained operating systems.

Which issue(s) this PR fixes:

xref kubermatic/kubermatic#11653

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Machine Controller no longer supports SLES operating system

Documentation:

https://github.com/kubermatic/docs/pull/1292

@ahmedwaleedmalik
Drop support for SLES
05444f2 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 9, 2023
@kubermatic-bot kubermatic-bot added docs/provided Denotes a PR that has a valid documentation reference. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 9, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws-arm

1 similar comment
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws-arm

@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Jan 10, 2023
Closed
1 task
@kron4eg
Copy link
Member

kron4eg commented Jan 12, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf7737304a41f4ed1357fd32d3db7474db4c7b47

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member Author

/hold to avoid retries
The failures are unrelated to this PR.

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-kubevirt pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jan 16, 2023 •
edited
Loading

@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-openstack 05444f2 link false /test pull-machine-controller-e2e-openstack

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik
Copy link
Member Author

@xrstf can you please override the unrelated CI jobs?

  • pull-machine-controller-e2e-kubevirt
  • pull-machine-controller-e2e-vsphere

@ahmedwaleedmalik
Copy link
Member Author

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2023
@xrstf
Copy link
Contributor

xrstf commented Jan 16, 2023

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-kubevirt, pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-kubevirt
/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 48a0136 into kubermatic:main Jan 16, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the nuke-sles branch January 16, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/provided Denotes a PR that has a valid documentation reference. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahmedwaleedmalik @kron4eg @kubermatic-bot @kubermatic-triage-bot @xrstf