Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Kubernetes version 1.26 #1522

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Add support for Kubernetes version 1.26 #1522

merged 3 commits into from
Jan 9, 2023

Conversation

ahmedwaleedmalik
Copy link
Member

Signed-off-by: Waleed Malik [email protected]

What this PR does / why we need it:
This PR does the following:

  1. Add support for Kubernetes v1.26
  2. Remove support for Kubernetes v1.23
  3. Update to the latest minor for supported Kubernetes versions.
  4. Remove support for configuring ConfigSource in machine spec.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature
/kind cleanup

Special notes for your reviewer:
Support for docker will be removed in a separate PR.

Does this PR introduce a user-facing change? Then add your Release Note here:

* Add support for Kubernetes v1.26
* Remove support for Kubernetes v1.23
* ConfigSource in Machine specs has been deprecated and is a no-op. Since the dynamic kubelet configuration feature has been removed starting from Kubernetes v1.24.

Documentation:

NONE

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jan 4, 2023
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 4, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws pull-machine-controller-e2e-aws-arm pull-machine-controller-e2e-aws-legacy-userdata pull-machine-controller-e2e-aws-spot-instance pull-machine-controller-e2e-azure pull-machine-controller-e2e-hetzner pull-machine-controller-e2e-openstack

@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-openstack

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as draft January 6, 2023 08:51
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws pull-machine-controller-e2e-azure

@ahmedwaleedmalik
Copy link
Member Author

  • Amazon Linux is failing for AWS
  • Flatcar is failing on Azure

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-aws pull-machine-controller-e2e-azure

@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review January 9, 2023 08:13
@ahmedwaleedmalik ahmedwaleedmalik changed the title WIP: Add support for Kubernetes version 1.26 Add support for Kubernetes version 1.26 Jan 9, 2023
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2023
@ahmedwaleedmalik
Copy link
Member Author

/test pull-machine-controller-e2e-azure

Flake

@kron4eg
Copy link
Member

kron4eg commented Jan 9, 2023

/retest pull-machine-controller-e2e-aws-arm

@kubermatic-bot
Copy link
Contributor

@kron4eg: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test pre-machine-controller-verify-shfmt
  • /test pull-kubermatic-machine-controller-validate-prow-yaml
  • /test pull-machine-controller-build
  • /test pull-machine-controller-dependencies
  • /test pull-machine-controller-e2e-anexia
  • /test pull-machine-controller-e2e-aws
  • /test pull-machine-controller-e2e-aws-arm
  • /test pull-machine-controller-e2e-aws-assume-role
  • /test pull-machine-controller-e2e-aws-centos8
  • /test pull-machine-controller-e2e-aws-ebs-encryption-enabled
  • /test pull-machine-controller-e2e-aws-flatcar-containerd
  • /test pull-machine-controller-e2e-aws-flatcar-coreos-cloud-init
  • /test pull-machine-controller-e2e-aws-legacy-userdata
  • /test pull-machine-controller-e2e-aws-sles
  • /test pull-machine-controller-e2e-aws-spot-instance
  • /test pull-machine-controller-e2e-azure
  • /test pull-machine-controller-e2e-azure-custom-image-reference
  • /test pull-machine-controller-e2e-custom-ca
  • /test pull-machine-controller-e2e-deployment-upgrade
  • /test pull-machine-controller-e2e-digitalocean
  • /test pull-machine-controller-e2e-gce
  • /test pull-machine-controller-e2e-hetzner
  • /test pull-machine-controller-e2e-invalid-objects-get-rejected
  • /test pull-machine-controller-e2e-kubevirt
  • /test pull-machine-controller-e2e-nutanix
  • /test pull-machine-controller-e2e-openstack-project-auth
  • /test pull-machine-controller-e2e-scaleway
  • /test pull-machine-controller-e2e-ubuntu-upgrade
  • /test pull-machine-controller-e2e-vmware-cloud-director
  • /test pull-machine-controller-e2e-vsphere
  • /test pull-machine-controller-e2e-vsphere-datastore-cluster
  • /test pull-machine-controller-e2e-vsphere-resource-pool
  • /test pull-machine-controller-license-validation
  • /test pull-machine-controller-lint
  • /test pull-machine-controller-test
  • /test pull-machine-controller-verify-boilerplate
  • /test pull-machine-controller-yamllint

The following commands are available to trigger optional jobs:

  • /test pull-machine-controller-e2e-alibaba
  • /test pull-machine-controller-e2e-azure-redhat-satellite
  • /test pull-machine-controller-e2e-equinix-metal
  • /test pull-machine-controller-e2e-linode
  • /test pull-machine-controller-e2e-openstack

Use /test all to run the following jobs that were automatically triggered:

  • pull-kubermatic-machine-controller-validate-prow-yaml
  • pull-machine-controller-build
  • pull-machine-controller-dependencies
  • pull-machine-controller-e2e-aws
  • pull-machine-controller-e2e-aws-arm
  • pull-machine-controller-e2e-aws-ebs-encryption-enabled
  • pull-machine-controller-e2e-aws-flatcar-containerd
  • pull-machine-controller-e2e-aws-legacy-userdata
  • pull-machine-controller-e2e-aws-spot-instance
  • pull-machine-controller-e2e-azure
  • pull-machine-controller-e2e-azure-custom-image-reference
  • pull-machine-controller-e2e-custom-ca
  • pull-machine-controller-e2e-digitalocean
  • pull-machine-controller-e2e-equinix-metal
  • pull-machine-controller-e2e-gce
  • pull-machine-controller-e2e-hetzner
  • pull-machine-controller-e2e-invalid-objects-get-rejected
  • pull-machine-controller-e2e-kubevirt
  • pull-machine-controller-e2e-openstack
  • pull-machine-controller-e2e-openstack-project-auth
  • pull-machine-controller-e2e-ubuntu-upgrade
  • pull-machine-controller-e2e-vmware-cloud-director
  • pull-machine-controller-e2e-vsphere
  • pull-machine-controller-license-validation
  • pull-machine-controller-lint
  • pull-machine-controller-test
  • pull-machine-controller-verify-boilerplate
  • pull-machine-controller-yamllint

In response to this:

/retest pull-machine-controller-e2e-aws-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kron4eg
Copy link
Member

kron4eg commented Jan 9, 2023

/test pull-machine-controller-e2e-aws-arm

@kron4eg
Copy link
Member

kron4eg commented Jan 9, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 9, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1d3ffe852855371bd3a6fa3ca7830a3df722b172

@ahmedwaleedmalik
Copy link
Member Author

I've requested an override for pull-machine-controller-e2e-aws-arm so that we can get this PR merged. It's failing due to capacity issues:

error InsufficientInstanceCapacity: We currently do not have sufficient a1.medium capacity in the Availability Zone you requested (eu-central-1a)

I'm going to test pull-machine-controller-e2e-aws-arm with my upcoming PRs.

@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Jan 9, 2023 •
edited
Loading

@ahmedwaleedmalik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-openstack e6cf830 link false /test pull-machine-controller-e2e-openstack

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xrstf
Copy link
Contributor

xrstf commented Jan 9, 2023

/override pull-machine-controller-e2e-aws-arm

AWS AZ is out of capacity.

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-aws-arm

In response to this:

/override pull-machine-controller-e2e-aws-arm

AWS AZ is out of capacity.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 067a36e into kubermatic:main Jan 9, 2023
@ahmedwaleedmalik ahmedwaleedmalik deleted the k8s-1.26 branch January 9, 2023 14:29
@xmudrii xmudrii mentioned this pull request Jan 18, 2023
Merged
@mfranczy
Copy link
Contributor

mfranczy commented Jan 18, 2023 •
edited
Loading

Also flatcar is failing on KubeVirt. I see from the job log of KubeVirt in this PR that tests were disabled. I will take a look to see what's wrong.

@mfranczy
Copy link
Contributor

Looks like it's connected to the thing that on our flatcar image we have containerd 1.5.4, probably it should be 1.6, meaning we have to update the flatcar image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ahmedwaleedmalik @kubermatic-bot @kron4eg @xrstf @mfranczy