Allow manually configuring containerd version via CLI flag

[dajudge]

What this PR does / why we need it:
A broken containerd release made it impossible for our setup to provision working new nodes. This was a result of machine-controller automatically installing the latest 1.6* release of containerd available.

This PR introduces the command line flag --node-containerd-version to manually pin the containerd version to install to a specific release.

The default for this new flag is empty, so the previously existing behavior remains intact if the flag is not specified.

Which issue(s) this PR fixes:
Implements partially kubermatic/kubeone#2545

What type of PR is this?
/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Introduce `--node-conterainerd-version` CLI flag.

Documentation:

NONE

[kubermatic-bot]

Hi @dajudge. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xmudrii]

Thanks a lot for this contribution, we really appreciate it! 🎉

I have one question, but other than that, LGTM.

[dajudge]

I also noticed that the containerd version gets overwritten to a legacy version in the case of AmazonLinux at the following places:

https://github.com/AtomicJar/machine-controller/blob/5d54195d47e9e78104f330bc877030b5cefd9740/pkg/containerruntime/docker.go#L98

https://github.com/AtomicJar/machine-controller/blob/5d54195d47e9e78104f330bc877030b5cefd9740/pkg/containerruntime/containerd.go#L77

Maybe it would make sense to move those if blocks above the switch to be below the latter so the value provided via CLI overrides this fallback? 🤔

[xmudrii]

Maybe it would make sense to move those if blocks above the switch to be below the latter so the value provided via CLI overrides this fallback?

I don't have strong opinions. Amazon Linux is a bit specific -- they ship only one specific version of containerd (and other relevant packages). I think, for consistency reasons, it might make sense to do so.

In the meanwhile, I'll trigger tests for this PR.
/test all

[dajudge]

Maybe it would make sense to move those if blocks above the switch to be below the latter so the value provided via CLI overrides this fallback?

To unblock this PR I've put above change on a separate branch.

Once this is PR here is on main I'd simply open a new PR and we can discuss it in detail there.

WDYT?

[xmudrii]

/lgtm
/approve

[kubermatic-bot]

LGTM label has been added.

Git tree hash: 847018c4e6ab0534b9e87d08bd0dd78d15182b61

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dajudge, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment