Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeVirt switch CI to DC... cleanup phase #1515

Merged
merged 1 commit into from
Dec 8, 2022

Conversation

hdurand0710
Copy link
Contributor

Signed-off-by: Helene Durand [email protected]

What this PR does / why we need it:
Now that all repos have been tested and everything is OK for the switch of KubeVirt CI to our DC, here is the cleanup phase.

  • I have updated the existing preset-kubevirt with the DC credentials.
  • I can now switch back to preset-kubevirt that targets Kv cluster in our DC in all repos.
  • I will then delete preset-kubevirt-dc from the infra repo.

In the vault:

  • e2e-kubevirt now contains the DC credentials
  • e2e-kubevirt-legacy contains the Equinix credentials.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

Signed-off-by: Helene Durand <[email protected]>
@hdurand0710 hdurand0710 added the sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. label Dec 8, 2022
@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 8, 2022
@hdurand0710
Copy link
Contributor Author

/test pull-machine-controller-e2e-kubevirt

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 16ff42f15a9f9b08682db92dd0eed37c16838248

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,hdurand0710]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit d40a14d into kubermatic:main Dec 8, 2022
@hdurand0710 hdurand0710 deleted the cleanup-switch-ci-dc branch December 9, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/virtualization Denotes a PR or issue as being assigned to SIG Virtualization. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants