Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.55] Anexia Provider: Utilize Creating state instead of blocking Create call #1510

Merged
merged 1 commit into from
Jan 3, 2023
Merged

[release/v1.55] Anexia Provider: Utilize Creating state instead of blocking Create call #1510

merged 1 commit into from
Jan 3, 2023

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1483

/assign ahmedwaleedmalik

Anexia: Refactor code to reduce provisioning time for node pools with multiple replicas.

@kubermatic-bot kubermatic-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Dec 7, 2022
@kubermatic-bot kubermatic-bot mentioned this pull request Dec 7, 2022
Merged
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 7, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: b1ac96e0f8d3508aa1c1787ba56514c0f298af43

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kubermatic-bot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

3 similar comments
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot
Copy link
Contributor Author

@kubermatic-bot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-azure-custom-image-reference 7890f19 link true /test pull-machine-controller-e2e-azure-custom-image-reference
pull-machine-controller-e2e-aws 7890f19 link true /test pull-machine-controller-e2e-aws
pull-machine-controller-e2e-vsphere 7890f19 link true /test pull-machine-controller-e2e-vsphere
pull-machine-controller-e2e-openstack-project-auth 7890f19 link true /test pull-machine-controller-e2e-openstack-project-auth
pull-machine-controller-e2e-kubevirt 7890f19 link true /test pull-machine-controller-e2e-kubevirt
pull-machine-controller-e2e-aws-legacy-userdata 7890f19 link true /test pull-machine-controller-e2e-aws-legacy-userdata
pull-machine-controller-e2e-openstack 7890f19 link true /test pull-machine-controller-e2e-openstack
pull-machine-controller-e2e-hetzner 7890f19 link true /test pull-machine-controller-e2e-hetzner
pull-machine-controller-e2e-ubuntu-upgrade 7890f19 link true /test pull-machine-controller-e2e-ubuntu-upgrade
pull-machine-controller-e2e-aws-flatcar-containerd 7890f19 link true /test pull-machine-controller-e2e-aws-flatcar-containerd
pull-machine-controller-e2e-digitalocean 7890f19 link true /test pull-machine-controller-e2e-digitalocean
pull-machine-controller-e2e-custom-ca 7890f19 link true /test pull-machine-controller-e2e-custom-ca
pull-machine-controller-e2e-aws-arm 7890f19 link true /test pull-machine-controller-e2e-aws-arm
pull-machine-controller-e2e-invalid-objects-get-rejected 7890f19 link true /test pull-machine-controller-e2e-invalid-objects-get-rejected
pull-machine-controller-e2e-aws-spot-instance 7890f19 link true /test pull-machine-controller-e2e-aws-spot-instance
pull-machine-controller-e2e-gce 7890f19 link true /test pull-machine-controller-e2e-gce
pull-machine-controller-e2e-deployment-upgrade 7890f19 link true /test pull-machine-controller-e2e-deployment-upgrade
pull-machine-controller-e2e-azure 7890f19 link true /test pull-machine-controller-e2e-azure
pull-machine-controller-e2e-aws-ebs-encryption-enabled 7890f19 link true /test pull-machine-controller-e2e-aws-ebs-encryption-enabled

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik
Copy link
Member

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2022
@ahmedwaleedmalik ahmedwaleedmalik merged commit 87a0dbc into kubermatic:release/v1.55 Jan 3, 2023
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1483-to-release/v1.55 branch October 4, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubermatic-bot @kubermatic-triage-bot @ahmedwaleedmalik