Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.54] Anexia Provider: Utilize Creating state instead of blocking `Create… #1509

Merged
merged 1 commit into from
Dec 7, 2022
Merged

[release/v1.54] Anexia Provider: Utilize Creating state instead of blocking `Create… #1509

merged 1 commit into from
Dec 7, 2022

Conversation

LittleFox94
Copy link
Contributor

What this PR does / why we need it:

Manual cherry-pick of #1483

What type of PR is this?
/kind cleanup

Does this PR introduce a user-facing change? Then add your Release Note here:

Anexia: Refactor code to reduce provisioning time for node pools with multiple replicas.

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 7, 2022
@kubermatic-bot
Copy link
Contributor

Hi @LittleFox94. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 7, 2022
@LittleFox94
Copy link
Contributor Author

Since @ahmedwaleedmalik reviewed the original PR, it would probably make sense if you take a look at this one as well - thanks :)

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, LittleFox94

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d02030effebf9d082f6dc8cf25f7b0bd30af68a5

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2022
@LittleFox94
Copy link
Contributor Author

this should probably also go into release/v1.55, what do you think?

@ahmedwaleedmalik
Copy link
Member

this should probably also go into release/v1.55, what do you think?

In general 1.55 is only used in KubeOne at the moment. I have added the backport though.

@LittleFox94
Copy link
Contributor Author

this should probably also go into release/v1.55, what do you think?

In general 1.55 is only used in KubeOne at the moment. I have added the backport though.

just thought it might be weird to have a change in main and a release older than the latest one, but not in the latest release - thanks :)

@ahmedwaleedmalik
Copy link
Member

/retest

@kubermatic-bot
Copy link
Contributor

@LittleFox94: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-machine-controller-e2e-hetzner 9c0b5b6 link true /test pull-machine-controller-e2e-hetzner
pull-machine-controller-e2e-vsphere 9c0b5b6 link true /test pull-machine-controller-e2e-vsphere

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ahmedwaleedmalik ahmedwaleedmalik merged commit d0d8cf3 into kubermatic:release/v1.54 Dec 7, 2022
@LittleFox94 LittleFox94 deleted the anexia-optimize-node-creation-v1.54 branch December 7, 2022 12:32
@LittleFox94
Copy link
Contributor Author

Hi @ahmedwaleedmalik,
since we still use KKP 2.20, we'd need this backported to v1.45 as well - could you cherry-pick this or should we create the PR manually?

@ahmedwaleedmalik
Copy link
Member

Hi @ahmedwaleedmalik, since we still use KKP 2.20, we'd need this backported to v1.45 as well - could you cherry-pick this or should we create the PR manually?

I'll take care of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LittleFox94 @kubermatic-bot @ahmedwaleedmalik @marioreggiori