-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set EvictionStrategy to external on KubeVirt VMs #1504
Set EvictionStrategy to external on KubeVirt VMs #1504
Conversation
Signed-off-by: Moritz Bracht <[email protected]>
Signed-off-by: Moritz Bracht <[email protected]>
Signed-off-by: Moritz Bracht <[email protected]>
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a small comment
Signed-off-by: Moritz Bracht <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
LGTM label has been added. Git tree hash: 8038c9d5b656c64b94336a7fc27978a940f21571
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dermorz, mfranczy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
This change will block automatic VMs eviction which will then need to be handled externally. kubermatic/kubermatic#11562
What type of PR is this?
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: