Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeVirt small cleanup: Flavor and PodAffinity #1494

Merged
merged 1 commit into from
Nov 23, 2022
Merged

KubeVirt small cleanup: Flavor and PodAffinity #1494

merged 1 commit into from
Nov 23, 2022

Conversation

hdurand0710
Copy link
Contributor

Signed-off-by: Helene Durand [email protected]

What this PR does / why we need it:
A small cleanup for Flavor and PodAffinity for KubeVirt.

  • Removed even the // Deprecated from the example
  • Removed useless MD fields in the e2e tests (they were already have no effect on the VM)
    This PR is part of KKP + dashboard + machine-controller cleanup of any existing useless code/example/doc for GA.

Which issue(s) this PR fixes:

Fixes #1492

What type of PR is this?

/kind cleanup

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 23, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d42337ec4a18cd5dbb847ea765ff7a04701c0ce

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,hdurand0710]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 68b11ac into kubermatic:main Nov 23, 2022
@hdurand0710 hdurand0710 deleted the 1492-cleanup branch November 24, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KubeVirt 2.21 to 2.22 migration: cleanup
3 participants
@hdurand0710 @kubermatic-bot @ahmedwaleedmalik