Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeVirt deprecate Flavor - no migration #1491

Merged
merged 1 commit into from
Nov 22, 2022
Merged

KubeVirt deprecate Flavor - no migration #1491

merged 1 commit into from
Nov 22, 2022

Conversation

hdurand0710
Copy link
Contributor

@hdurand0710 hdurand0710 commented Nov 21, 2022 •
edited
Loading

Signed-off-by: Helene Durand [email protected]

What this PR does / why we need it:
Now the the UI has done the migration from Flavor to Instancetype/Preference, we deprecate it in the machine-controller.
No automatic migration is done, it will be manual for existing MD (KubeVirt is Tech Preview till KKP 2.21)

Which issue(s) this PR fixes:

Fixes #1490

What type of PR is this?

/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

KubeVirt: deprecation of Flavor (in favour of Instancetype/Preference)

Documentation:

TBD

@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/tbd Denotes a PR that needs documentation (change) that will be done later. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 21, 2022
@sankalp-r
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 909442388b29f23fa32453b44f30d57d1fbe6a46

mfranczy
mfranczy approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@mfranczy mfranczy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, hdurand0710, mfranczy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@hdurand0710
Copy link
Contributor Author

/retest

@xrstf
Copy link
Contributor

xrstf commented Nov 22, 2022

/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 40cb0e4 into kubermatic:main Nov 22, 2022
@hdurand0710 hdurand0710 deleted the 1490-deprecate-flavor branch November 22, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@mfranczy mfranczy mfranczy approved these changes

Assignees

@sankalp-r sankalp-r

@ahmedwaleedmalik ahmedwaleedmalik

@mfranczy mfranczy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KubeVirt deprecate Flavor in favor of instancetype/preference
6 participants
@hdurand0710 @sankalp-r @kubermatic-bot @xrstf @ahmedwaleedmalik @mfranczy