Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.54] Update filter for CentOS Linux images #1487

Merged
merged 2 commits into from
Nov 23, 2022
Merged

[release/v1.54] Update filter for CentOS Linux images #1487

merged 2 commits into from
Nov 23, 2022

Conversation

dermorz
Copy link
Contributor

@dermorz dermorz commented Nov 16, 2022

What this PR does / why we need it:
CentOS changed their image names in a way our filters did not match anymore: https://wiki.centos.org/Cloud/AWS

Does this PR introduce a user-facing change? Then add your Release Note here:

Update CentOS AMI filter

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2022
@dermorz dermorz changed the title Backport centos image filters to 1.54 [release/v1.54] Update filter for CentOS Linux images Nov 16, 2022
@kubermatic-bot kubermatic-bot added the sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. label Nov 16, 2022
@dermorz
Copy link
Contributor Author

dermorz commented Nov 16, 2022

/retest

1 similar comment
@mate4st
Copy link
Contributor

mate4st commented Nov 16, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6803269837c41d1e7ec96847ed8ba4caa22af28e

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, dermorz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2022
@kubermatic-bot kubermatic-bot merged commit 28f11b5 into kubermatic:release/v1.54 Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dermorz @mate4st @kubermatic-bot @ahmedwaleedmalik